-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SolaraViz docs #2494
Comments
I agree that this should be documented and added to |
@Corvince I would like to contribute to this issue. |
Thats great to hear! Sorry for not responding earlier. If you have any specific question just ask, otherwise I am looking forward to your PR |
@Corvince is final pr merged, ? (if it is then please close issue , as it's confusing) |
No the root issue is not resolved at all. In fact, its an upstream problem in solara. What is merged is only another PR that mentioned this issue. |
SolaraViz creates new model instances via
**model_parameters.value
. This implies that all inputs for instantiating a new model are keyword arguments. This is currently not well documented, and we might even consider adding this as an explicit check in_check_model_params
.The text was updated successfully, but these errors were encountered: