Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

Ensure all role variables are prefixed #376

Closed
mike-nguyen opened this issue Apr 16, 2018 · 2 comments
Closed

Ensure all role variables are prefixed #376

mike-nguyen opened this issue Apr 16, 2018 · 2 comments
Labels

Comments

@mike-nguyen
Copy link
Collaborator

The role variables should be prefixed and adhere to the openshift style guide [0]. Most of the roles already do this but I noticed some that don't. I've run into issues using include_role where there are variable collisions that were resolved when using prefixed variable names.

[0] https://github.com/openshift/openshift-ansible/blob/master/docs/style_guide.adoc#Role-variables-MUST-have-a-prefix-of-atleast-3-characters-See.below.for.specific.naming.rules

@miabbott
Copy link
Collaborator

This looks like #224

We should close one of these; I don't really care which one...

@miabbott miabbott added the bug label Apr 17, 2018
@mike-nguyen
Copy link
Collaborator Author

I'll close this one in favor of #224

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants