Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

perform audit of roles to print expected values when doing comparisons #239

Open
miabbott opened this issue Aug 25, 2017 · 0 comments
Open

perform audit of roles to print expected values when doing comparisons #239

miabbott opened this issue Aug 25, 2017 · 0 comments
Labels
enhancement

Comments

@miabbott
Copy link
Collaborator

As pointed out in #238, some of our roles are doing value comparisons, but the error messages do not include the expected values.

We should do an audit of the roles to make sure we are including the expected values in any error messages that are printed.
@miabbott miabbott mentioned this issue Sep 25, 2017
Closed
@miabbott miabbott mentioned this issue Oct 2, 2017
Closed
@miabbott miabbott mentioned this issue Dec 11, 2017
Merged
mike-nguyen added a commit to mike-nguyen/atomic-host-tests that referenced this issue Dec 12, 2017
@mike-nguyen
Improve error messages in tests
0042d9d 
This is the follow on to projectatomic#288 to address projectatomic#239.  projectatomic#288 addressed the
error messages in the roles and this commit addresses the error
messages in the tests itself.
@mike-nguyen mike-nguyen mentioned this issue Dec 12, 2017
Merged
miabbott pushed a commit that referenced this issue Dec 12, 2017
@mike-nguyen
Improve error messages in tests (#290)
6ad66c9 
* Improve error messages in tests

This is the follow on to #288 to address #239.  #288 addressed the
error messages in the roles and this commit addresses the error
messages in the tests itself.

* fixup! Improve error messages in tests
@miabbott miabbott removed the jira label Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miabbott @mike-nguyen