Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: Exit 1 if docusaurus build fails #95

Merged
merged 2 commits into from
Aug 20, 2024
Merged

patch: Exit 1 if docusaurus build fails #95

merged 2 commits into from
Aug 20, 2024

Conversation

vipulgupta2048
Copy link
Member

@vipulgupta2048 vipulgupta2048 commented Aug 14, 2024 •
edited
Loading

This should fail the workflow when docusaurus fails to build. Atm, the master branch is broken and #94 will fix it.

This PR is created to make sure Flowzone fails and that's what happened on the previous run which validates the functionality of this PR: https://github.com/product-os/docusaurus-builder/actions/runs/10389536198/job/28767954123

at Z (server.bundle.js:14787:89)
              at Yc (server.bundle.js:14790:98)
        },
        Error: Can't render static file for pathname "/"
            at generateStaticFile (/app/node_modules/@docusaurus/core/lib/ssg.js:119:15)
            at async /app/node_modules/p-map/index.js:57:22 {
          [cause]: TypeError: (0 , lib_namespaceObject.useContextualSearchFilters) is not a function
              at SearchBar (server.bundle.js:8676:833)
              at Uc (server.bundle.js:14779:44)
              at Xc (server.bundle.js:147[81](https://github.com/product-os/docusaurus-builder/actions/runs/10389536198/job/28767954123#step:7:82):253)
              at Z (server.bundle.js:14787:89)
              at Yc (server.bundle.js:14790:98)
              at Xc (server.bundle.js:147[82](https://github.com/product-os/docusaurus-builder/actions/runs/10389536198/job/28767954123#step:7:83):145)
              at Z (server.bundle.js:14787:89)
              at Xc (server.bundle.js:14781:481)
              at Z (server.bundle.js:14787:89)
              at Yc (server.bundle.js:14790:98)
        }
      ]
    }
  }
}
[INFO] Docusaurus version: 3.5.1
Node version: v18.20.3
An error occurred. Exiting with status code 1.

Also, removing the throw errors for broken links and markdown files to not break build pipelines since this PR will fail anything with an error.

Signed-off-by: Vipul Gupta (@vipulgupta2048) [email protected]

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

Website deployed to CF Pages, 👀 preview link https://c24ceb70.docusaurus-builder.pages.dev

@flowzone-app flowzone-app bot enabled auto-merge August 14, 2024 14:11
@vipulgupta2048 vipulgupta2048 force-pushed the vipulgupta2048/fail-action branch 5 times, most recently from b3ce41c to 0a23249 Compare August 14, 2024 22:12
@vipulgupta2048 vipulgupta2048 linked an issue Aug 16, 2024 that may be closed by this pull request
Should be able to self-test this workflow locally #52
Open
@vipulgupta2048 vipulgupta2048 force-pushed the vipulgupta2048/fail-action branch from 0a23249 to a4800c5 Compare August 20, 2024 12:41
@vipulgupta2048
Copy link
Member Author

@balena-ci I self-certify!

@flowzone-app flowzone-app bot merged commit d9d3ee4 into master Aug 20, 2024
48 checks passed
@flowzone-app flowzone-app bot deleted the vipulgupta2048/fail-action branch August 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should be able to self-test this workflow locally
1 participant
@vipulgupta2048