Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in perfectElimOrder function #1

Open
Tonyecl opened this issue Apr 10, 2015 · 1 comment
Open

A bug in perfectElimOrder function #1

Tonyecl opened this issue Apr 10, 2015 · 1 comment

Comments

@Tonyecl
Copy link

Tonyecl commented Apr 10, 2015

Hi, I think I've found a bug in "perfectElimOrder.m".

the following code

"G = [ 0 1/3 0 0 ;
1/2 0 0 1/2 ;
0 0 0 1/2 ;
0 1/2 1/2 0];

[order, chordal, cliques, numpa] = perfectElimOrder(G,1);
cliques{3}"

generate 3rd clique as
">> cliques{3}
ans =
4 4"

The problem is in line 47 => "C{i} = [pa i];" should be replaced by "C{i} = [pa u];". It gives in this case:
"cliques{3}
ans =
4 3"
which is correct and confirmed by another similar function : "maxCardinalitySearch.m".

There is also a problem when the starting initial node choice in "perfectElimOrder.m". Nothing works except the case where "initNode=1" which is default value.

Regards
Anton

@Tonyecl
Copy link
Author

Tonyecl commented Apr 10, 2015

To avoid the second problem I've just commented line 30, it seems to work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant