Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt out of SVG optimisation #76

Open
daithimaolain opened this issue Jun 26, 2023 · 2 comments
Open

Opt out of SVG optimisation #76

daithimaolain opened this issue Jun 26, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@daithimaolain
Copy link

The built-in loader for PrismicNextImage produces a srcset on the image tag for svg images. This behaviour seems to be redundant. Should you rather opt in to this much the same way as it works for the underlying Image component.

@daithimaolain daithimaolain added the enhancement New feature or request label Jun 26, 2023
@github-actions
Copy link

This issue has been labeled as a feature request since it was created using the 🙋‍♀️ Feature Request Template.

Hi there, thank you so much for your request!

Following our Maintenance Process, we will review your request and get back to you soon. If we decide to implement it, will proceed to implement the feature during the last week of the month. In the meantime, feel free to provide any details to help us better understand your request, such as:

  • The context that made you think of this feature request
  • As many details about the solution you'd like to see implemented, how it should behave, etc.
  • Any alternative solution you have considered

If you think you can implement the proposed change yourself, you're more than welcome to open a pull request implementing the new feature. Check out our quick start guide for a simple contribution process. Please note that submitting a pull request does not guarantee the feature will be merged.

- The Prismic Open-Source Team

@angeloashmore
Copy link
Member

Good idea! This should be doable, though I'm not sure we can respect the global images.dangerouslyAllowSVG config value. We'll leave this request open until we are able to work on and publish the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants