Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff highlighting sometimes accidentally applied to code blocks #11

Open
imchairmanm opened this issue Jun 24, 2020 · 3 comments
Open
Labels
web/bug Bug with the Data Guide website

Comments

@imchairmanm
Copy link
Contributor

Since code blocks automatically apply highlighting to lines beginning with +, -, and |, sometimes the styling is applied to code blocks where it doesn't make sense.

For instance, in SQL files, single line comments marked with two dashes --. Another example is that psql uses a line of dashes to separate labels from values. These are interpreted as diff line removal highlighting, however:

Screenshot from 2020-06-22 14-18-03

It'd be helpful to be able to disable this or to have it be enabled by a property you can add manually instead of automatically applying when one of those characters are at the start of a line.

@etelsv etelsv added web/candidate Candidate for next Web Sprint and removed web/candidate Candidate for next Web Sprint labels Jul 28, 2020
@janpio
Copy link
Contributor

janpio commented Sep 14, 2020

Possible workaround:
I noticed the bug in the highlighting of the tables, that the separator between header and data always is highlighted red. I tried a quick idea in a PR: https://deploy-preview-71--dataguide.netlify.app/postgresql/reading-and-querying-data/filtering-data#conclusion (above the "Conclusion headline"). Adding a space in front of all the lines of the table output could avoid that bug if it is not going to be fixed soon: #71

@imchairmanm
Copy link
Contributor Author

Just looking through some older issues. This is still unresolved.

I don't know if we've ever purposefully used the diff highlighting for content in the Data Guide so I'd be happy if we just disabled / removed it if that's the easiest solution.

@janpio
Copy link
Contributor

janpio commented Dec 1, 2022

(Same problem exists in docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web/bug Bug with the Data Guide website
Projects
None yet
Development

No branches or pull requests

3 participants