Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpvo ---colmap #68

Open
li1u opened this issue Aug 10, 2024 · 4 comments
Open

dpvo ---colmap #68

li1u opened this issue Aug 10, 2024 · 4 comments

Comments

@li1u
Copy link

li1u commented Aug 10, 2024

Hello, I am amazed by the effect of your article. But I have some questions to ask you.

First, when I use video data, the visualization result is good, but the stored result.ply file is not good.
image
image

Second, there are still some differences between the cameras.txt and other files in the result folder and the standard colmap data. I don’t know whether your code provides an interface for storing as standard colmap data.

@lahavlipson
Copy link
Collaborator

Unfortunately, I am not able to reproduce this issue. If you could point me to an example which reproduces the problem, that would be very helpful for me.

The --colmap flag saves a directory which can be opened using:
colmap gui -> select file, import model -> select path/to/dpvo-output -> select no to only visualize reconstruction

When I do this on the demo from the colab notebook, I get:

Screenshot 2024-08-10 at 11 18 22 AM

FYI: The --colmap output does not contain information about the 2D feature tracks, since I assumed most people just wanted the camera poses and maybe a sparse reconstruction. If this would be helpful for people, I could add it.

@li1u
Copy link
Author

li1u commented Aug 12, 2024

Yes, it really works for me, hope you can add it.

@ljjTYJR
Copy link

ljjTYJR commented Sep 30, 2024

@lahavlipson By the way, I think there is a minor error when saving the camera intrinsic parameter here:
In the COLMAP doc, when saving the camera parameters should be

# Camera list with one line of data per camera:
#   CAMERA_ID, MODEL, WIDTH, HEIGHT, PARAMS[]
# Number of cameras: 3
1 SIMPLE_PINHOLE 3072 2304 2559.81 1536 1152
2 PINHOLE 3072 2304 2560.56 2560.56 1536 1152
3 SIMPLE_RADIAL 3072 2304 2559.69 1536 1152 -0.0218531

but in the code, it is saved as

(colmap_dir / "cameras.txt").write_text(f"1 PINHOLE {H} {W} {fx} {fy} {cx} {cy}")

I think it should be

 (colmap_dir / "cameras.txt").write_text(f"1 PINHOLE {W} {H} {fx} {fy} {cx} {cy}") 

@lahavlipson
Copy link
Collaborator

@ljjTYJR Thanks for catching that. It's now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants