alloptions race conditions

[soulseekah]

https://core.trac.wordpress.org/ticket/31245

Raised by @mihadan and probably @msigley when he said "the notorious 'alloptions' bug" in #13 (comment)

Handled in PR #6 for now, but needs a refresh.

[soulseekah]

Why didn't they use https://github.com/soulseekah/wp-lock 😸 ?

Are there any race conditions in our preloaded implementation?

[msigley]

Yes there are. The race condition occurs on sets to different keys on concerent requests. It occurs because all of the values are stored in one big blob instead of individual keys.

[msigley]

The fix for redis would be to replace the alloptions key with an mget.