Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ad size in the GMA SDK + Rendering API integration scenario #1073

Open
YuriyVelichkoPI opened this issue Dec 11, 2024 · 0 comments

Comments

@YuriyVelichkoPI
Copy link
Contributor

Motivation

The issue described in the slack channel:

Ads don’t stretch to full width. As soon as we turn on the Prebid SDK, the ads appear smaller (like the one on the right in the images below). When we switch to only serving ads from Google, they scale properly in both width and height. Additionally, to the list of valid sizes, we are also sending GADInlineAdaptiveBannerAdSizeWithWidthAndMaxHeight.

Without Prebid
With Prebid

Additional information: the way that the publisher uses to set the ad sizes:

defaultAdSize(source: source),
        CGSize(width: 250, height: 250),
        CGSize(width: 300, height: 100),
        CGSize(width: 300, height: 250),
        CGSize(width: 320, height: 50),
        CGSize(width: 320, height: 160),
        CGSize(width: 320, height: 320)

let adSize = GADInlineAdaptiveBannerAdSizeWithWidthAndMaxHeight(boundingWidth, defaultAdSize.height)
      validAdSizes.append(NSValueFromGADAdSize(adSize)) (edited)

Objectives

  • Figure out the reason for the incorrect display and fix it.
  • Make sure that all sizes are passed to the GAM properly.

There is an additional question that we should encounter in the scope of this ticket:

We’ve also noticed that the number of advertisers drops significantly when Prebid is on, and all ads seem to come through as smaller formats. When we turn off Prebid, there’s much more variety in advertisers, and ad sizes go back to normal.

It can happen due to the corrupted request info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

1 participant