Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async: Don't use testFunc.toString to guess argument names or count #28

Open
mcbain opened this issue Dec 29, 2014 · 1 comment
Open

Comments

@mcbain
Copy link

mcbain commented Dec 29, 2014

http://stackoverflow.com/questions/1007981/how-to-get-function-parameter-names-values-dynamically-from-javascript

These technique does not work when using code-minification ( --production flag) or a function-wrapper without (test,waitFor) args in source-code.

Please allow to flag a test to be 'async' e.g

      it.async = function (name, fn) {
       it(name, function (test, waitFor) {
        return fn.apply(this, arguments);
    });
      };
@rbabayoff
Copy link
Member

OK, will take a look at it when we're back form vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants