Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag when USB device goes to sleep/wakes up #31325

Closed
invtblWalrus opened this issue Dec 28, 2024 · 5 comments
Closed

Lag when USB device goes to sleep/wakes up #31325

invtblWalrus opened this issue Dec 28, 2024 · 5 comments

Comments

@invtblWalrus
Copy link

invtblWalrus commented Dec 28, 2024

Type

Performance

Bug description

Bit of a weird one, and it took me a while to figure out what was happening at all. It seems that lazer lags when a USB device (in this case my mouse) goes to sleep or wakes up. My temporary workaround is to just turn my mouse off entirely and use my tablet, but this doesn't happen in stable, I can even disconnect and reconnect my mouse entirely without the game stuttering.

I'd prefer to leave my mouse on during gameplay for when I need to tab to my other monitor/click specific UI elements/etc.

Can provide additional details if they'll help.

For clarity, I slowed down the first video to make the graphs easier to see at 60fps.

Screenshots or videos

Osulazerlag1-2.mp4
osulazerlag2.mp4

Version

2024.1224.1

Logs

compressed-logs.zip

@bdach
Copy link
Collaborator

bdach commented Dec 30, 2024

This is more or less ppy/osu-framework#6181 again, and will likely be resolved along with it (if that one ever gets resolved).

@bdach bdach closed this as not planned Won't fix, can't repro, duplicate, stale Dec 30, 2024
@Susko3
Copy link
Member

Susko3 commented Jan 11, 2025

Correct, but this is a useful repro case.

@invtblWalrus could I ask you to do some testing for me?

I see you are using single-threaded mode. Could you test in multithreaded and compare the behaviour? (Please provide screen recordings and logs.)

Could you also test both threading modes in SDL3? Set the user environment variable OSU_SDL3 to 1, and then open osu!(lazer).

@invtblWalrus
Copy link
Author

Correct, but this is a useful repro case.

@invtblWalrus could I ask you to do some testing for me?

I see you are using single-threaded mode. Could you test in multithreaded and compare the behaviour? (Please provide screen recordings and logs.)

Could you also test both threading modes in SDL3? Set the user environment variable OSU_SDL3 to 1, and then open osu!(lazer).

No problem.

2 videos attached, one is turning on and off my mouse with osu!lazer running in single-threading, other in multi-threaded. The issue is present in both.

Mousedisconnected-Singlethread-compressed.mp4
Mousedisconnected-Multithread-compressed.mp4

I did both of these with the user environment variable set to 1, though I'm not 100% sure I did that correct (maybe this screenshot will tell you I did something wrong.)
image

Logs as well attached.
compressed-logs.zip

Let me know if there's anything else I can provide to assist.

@Susko3
Copy link
Member

Susko3 commented Jan 11, 2025

It's not set correctly, you can tell by the "Mode: Borderless (SDL2)" above the FPS meters. Make sure that there aren't any spaces around the variable name and value. Type out the values as copying can sometimes include trailing spaces.

@invtblWalrus
Copy link
Author

I think I just forgot to hit OK on the second dialogue so it didn't set correctly, oops.

Attaching 2 new videos here:

Mousedisconnect-Sdl3-Single.mp4
Mousedisconnect-Sdl3-Multi.mp4

Fresh logs:
compressed-logs.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants