Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tablet hovering impossible without turning on "Tablet" option in input settings. #30641

Open
Dirtinator opened this issue Nov 15, 2024 · 20 comments
Labels
priority:0 Showstopper. Critical to the next release. sdl issue type:input

Comments

@Dirtinator
Copy link

Dirtinator commented Nov 15, 2024

Type

Game behaviour

Bug description

After the most recent update (Lazer 2024.1115.1) the game is incapable of properly detecting my tablet unless I drag it.

If I hover it behaves incorrectly, both as if it had absolute positioning (like a mouse) and partially like normal, jumping between the 2 rapidly.

This has not happened in any previous cases of me playing on Lazer in the past (approximately) year.

The tablet (CTL-472 Wacom) works without issue outside of osu! and this seems to be exclusively when focus is set on the osu! executable.

ADDITIONAL INFO: after making this post I checked to see if I could find an option to fix this and tried turning off "high precision mouse" which simply caused the game to not detect hovering at all instead of doing so in a broken fashion. it still however detected dragging like normal.

Screenshots or videos

Screen.recorder_11-15-2024_11-27-17-215.mp4

During the test I was doing square and circular motion to demonstrate the issue.

Version

Lazer 2024.1115.1

Logs

compressed-logs.zip

Tasks

No tasks being tracked yet.
@100925afg
Copy link

100925afg commented Nov 15, 2024

I also have the same problem.After this update,my tablet(GAOMON 1061PRO) can't move correctly and sometimes can't move to the edge. But it didn't happen at the previous version.: (

I also tried to turn off the "high precision mouse",then it fixed(Even though my tablet didn't have supportive driver for osu).
Thanks for your suggestion!

@ppy ppy deleted a comment from 100925afg Nov 15, 2024
@SupDos
Copy link
Contributor

SupDos commented Nov 15, 2024

Possibly related/duplicate of #28223

@Dirtinator
Copy link
Author

#30641 (comment) yes I did try that after I made the post and have since added the information that it somehow worsens the issue and the game doesn't detect hovering at all.

@SupDos
Copy link
Contributor

SupDos commented Nov 15, 2024

I'm assuming you turned it off in lazer, right? Someone in the dev discord thought they had to change the Windows mouse setting, but changing the setting in lazer fixed it for them

@Dirtinator
Copy link
Author

Yes the setting was changed in the in-game setting "high precision mouse" and doing so made the game not recognize hovering at all. with it turned on it is in a broken state. Dragging seems to be unaffected.

@Dirtinator
Copy link
Author

Yeah there also seems to be a separate issue when I have tablet mode enabled in general and hovering though not nearly as major.
The cursor seems to constantly shake very slightly when hovering (tablet mode enabled) and this scales the higher up the pen is held (more distance between the tablet = more violent shaking). the shaking in proportion to the game is miniscule however, less than half a millimeter on the monitor (most likely singular pixels) but when held further it does deviate in position up around 4-5mm.

@bdach
Copy link
Collaborator

bdach commented Nov 15, 2024

So I guess we turn off SDL3 once more? cc @ppy/team-client

@Susko3
Copy link
Member

Susko3 commented Nov 15, 2024

@Dirtinator @100925afg Can you record a video of it being broken again, but have Global Statistics open (Ctrl-F2) and showing the Input sections.

@100925afg also please send the logs.

@bdach bdach added priority:0 Showstopper. Critical to the next release. type:input sdl issue labels Nov 15, 2024
@Susko3
Copy link
Member

Susko3 commented Nov 15, 2024

There are also a few SDL error logs, not sure what those are about:

2024-11-15 10:08:59 [verbose]: SDL error log [debug]: Invalid window
2024-11-15 10:09:06 [verbose]: Received beatmap updates 1 updates with last id 8687711
2024-11-15 10:09:14 [verbose]: SDL error log [debug]: No HID devices found in the system.
2024-11-15 10:09:14 [verbose]: SDL error log [debug]: No HID devices found in the system.
2024-11-15 10:09:14 [verbose]: SDL error log [debug]: No HID devices found in the system.
2024-11-15 10:09:14 [verbose]: SDL error log [debug]: No HID devices found in the system.
2024-11-15 10:09:14 [verbose]: SDL error log [debug]: No HID devices found in the system.
2024-11-15 10:09:20 [verbose]: SDL error log [debug]: No HID devices found in the system.
2024-11-15 10:09:20 [verbose]: SDL error log [debug]: No HID devices found in the system.
2024-11-15 10:09:20 [verbose]: SDL error log [debug]: No HID devices found in the system.
2024-11-15 10:09:39 [verbose]: SDL error log [debug]: Invalid window
2024-11-15 10:09:43 [verbose]: SDL error log [debug]: Invalid window

@Dirtinator
Copy link
Author

This is in regards to the hovering not working properly.

Screen.recorder_11-15-2024_12-15-27-90.mp4

This is in regards to the shaking while hovering (tablet mode)

Screen.recorder_11-15-2024_12-16-2-920.mp4

@Susko3
Copy link
Member

Susko3 commented Nov 15, 2024

@Dirtinator does hovering work in windowed mode? Try relative mouse mode both enabled and disabled. It should work better when disabled.

@100925afg
Copy link

100925afg commented Nov 15, 2024

@Susko3 I reinstall my tablet driver ,then it fixed completely.
But I still don't know why it can fixed that bug
(also close the "Tablet","Touch","High precision mouse" selection)
my tablet is GAOMON 1061pro

@100925afg
Copy link

Now the hovering part also can work(The Driver I use isn't OpenTabletDriver)

@100925afg
Copy link

compressed-logs.zip
I don't know if it is useful now...but i still upload my logs
@Susko3

@Dirtinator
Copy link
Author

@Susko3 Okay that does seem to have changed something. In windowed mode with high precision ON the issue persists however, with high precision OFF the issue disappears completely (and the shaking that was happening with tablet mode is not present). In borderless however the same thing happened as in the original post.

Unfortunately I get worse performance (massive lagspikes) when in windowed/borderless compared to fullscreen but for now the slight shaking isn't causing me any real problems so it's a functional band-aid fix.

@Susko3
Copy link
Member

Susko3 commented Nov 15, 2024

To summarise my testing with https://github.com/Teages/vTablet (Windows Ink):

  • clicking the pen always works as expected (absolute positioning)
  • if relative mode is enabled, hovering will be using relative mode so it wont work as expected. this is by SDL3 design
  • if relative mode is disabled, hovering works fine in windowed mode, but doesn't work in fullscreen and borderless
    • i'd say this is an SDL3 bug, or some windows weirdness

The real fix for all this is libsdl-org/SDL#10516.

@bdach
Copy link
Collaborator

bdach commented Nov 15, 2024

Which means one of us is going to need to take 2 weeks out to implement this for sdl because they likely don't have enough users to care. Which means, that short term, we probably revert sdl3 again.

@100925afg
Copy link

To summarise my testing with https://github.com/Teages/vTablet (Windows Ink):总结一下我在https://github.com/Teages/vTablet (Windows Ink)上的测试:

  • clicking the pen always works as expected (absolute positioning)点击笔总是按预期工作(绝对定位)
  • if relative mode is enabled, hovering will be using relative mode so it wont work as expected. this is by SDL3 design如果启用了相对模式,悬停将使用相对模式,因此它不会像预期的那样工作。这是由SDL3设计的
  • if relative mode is disabled, hovering works fine in windowed mode, but doesn't work in fullscreen and borderless
    如果禁用相对模式,悬停在窗口模式下可以正常工作,但在全屏和无边框模式下不起作用
    • i'd say this is an SDL3 bug, or some windows weirdness我想说这是SDL3的bug,或者是一些奇怪的窗口

The real fix for all this is libsdl-org/SDL#10516.真正的解决方法是 libsdl-org/SDL#10516 。

I turing off the "Windows Ink"selection in my tablet driver,so maybe this problem can be solved by banned the "Windows Ink Input"?
I can't make sure if my conjecture is correct,but this bug really didn't happen in my device now.

@Halbour
Copy link

Halbour commented Nov 15, 2024

I confirm I also have this problem, using the same Tablet as OP.

@Dirtinator
Copy link
Author

@Susko3 Sorry if this is pedantic but should I also create a separate issue for what I mentioned in #30641 (comment)?

I can't do so at the moment as I do not have access to my computer but if it would help with organizing I can do so in 2-3 hours unless there is no point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:0 Showstopper. Critical to the next release. sdl issue type:input
Projects
None yet
Development

No branches or pull requests

6 participants