Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak and freezing on Experimental Direct3D renderer #28855

Closed
dee-eep opened this issue Jul 14, 2024 · 7 comments · Fixed by ppy/osu-framework#6331
Closed

Memory leak and freezing on Experimental Direct3D renderer #28855

dee-eep opened this issue Jul 14, 2024 · 7 comments · Fixed by ppy/osu-framework#6331
Assignees
Labels
osu!framework issue Can't resolve this without changes to osu!framework. renderer/directx

Comments

@dee-eep
Copy link

dee-eep commented Jul 14, 2024

Type

Performance

Bug description

After playing for a while in a session (>10 minutes), I would notice that the game would occasionally freeze for half a second and then continue as normal. This freezing would start by happening around once a minute or so, then over time become more and more frequent. I checked task manager and saw osu using over 5gb of ram (went down to 3gb while I was tabbed out and typing this, still excessive compared to the around 500mb it used to use), so I'm assuming that this is caused by a memory leak and is causing the freezes as well.

I use the experimental renderer since I noticed significant input lag decrease and some fps increase over the normal Direct3D renderer. This issue started from the latest update (2024.625.0 I think); it did not occur before. I am using a Galaxy Book3 Pro 360 with an eGPU (AMD RX 6800) however Windows is set to not use the eGPU for osu.

I've seen bug reports for the Vulkan experimental and OpenGL renderers but not Direct3D experimental

Screenshots or videos

image

Version

2024.625.2

Logs

compressed-logs.zip

@Joehuu
Copy link
Member

Joehuu commented Jul 14, 2024

Experimental renderer issues go in #27659.

@Joehuu Joehuu closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2024
@smoogipoo
Copy link
Contributor

smoogipoo commented Jul 16, 2024

Going to reopen this one for now until it's confirmed to be isolated to the experimental renderer, because there was a similar/related issue here that was supposed to be resolved by ppy/veldrid#54 .

@dee-eep can you check if this happens on the non-experimental renderer? Also, is there any more information for how you're reproducing this:

  • Beatmap(s)?
  • Mods (the issue above occurred most often when a specific mod was selected)?
  • Skin? Please provide.

@smoogipoo smoogipoo reopened this Jul 16, 2024
@smoogipoo
Copy link
Contributor

I'm able to repro this on https://osu.ppy.sh/beatmapsets/17670#osu/62963 with the depth mod (as per previously mentioned issue). I'll treat it separate from all the other deferred renderer fails, because this one is a native memory leak.

@smoogipoo smoogipoo self-assigned this Jul 16, 2024
@smoogipoo smoogipoo added osu!framework issue Can't resolve this without changes to osu!framework. renderer/directx labels Jul 16, 2024
@dee-eep
Copy link
Author

dee-eep commented Jul 16, 2024

Hi, I won't be able to test for around 24 hours but here's information I know.

Happens on any beatmap, will provide some once I can test later
It happens with no mods selected
The skin is default osu argon pro edited, with the only change being adding the letter grade display which was added in a recent patch in the top right

I'll have more information tomorrow once I can test, but feel free to ask if any other info is needed

@dee-eep
Copy link
Author

dee-eep commented Jul 16, 2024

If it's important, if I hit a circle on time at the same time as the game freezes, it ends up giving me a 50 or a miss, even though multi threaded rendering is on

@smoogipoo
Copy link
Contributor

ppy/osu-framework#6331 Should fix this in the next release.

@dee-eep
Copy link
Author

dee-eep commented Jul 16, 2024

Just tested, memory usage didn't go over 1GB on D3D11 non-experimental

Skin:
osu_ argon pro (2022) (modified) (Unknown).zip

Just reproduced on D3D11 experimental by playing these 5 maps, memory usage hit almost 4GB:
https://osu.ppy.sh/beatmapsets/1727589#osu/3530438
https://osu.ppy.sh/beatmapsets/921889#osu/1928891
https://osu.ppy.sh/beatmapsets/596704#osu/1262271
https://osu.ppy.sh/beatmapsets/1674456#osu/3433650
https://osu.ppy.sh/beatmapsets/2161281#osu/4557702

I never used the depth mod but maybe I'm misunderstanding

EDIT: Just tried the depth mod, osu used 6gb of memory in 30 seconds, and my total committed memory grew to 60gb over 5 minutes after which osu crashed. A lot more extreme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
osu!framework issue Can't resolve this without changes to osu!framework. renderer/directx
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants