Video-related crashes on some maps due to apparently negative duration #17345

xeome · 2022-03-19T14:31:57Z

Type

Crash to desktop

Bug description

system information:
operating system: endeavouros (arch based)
kernel: latest zen kernel
gpu: gtx 760
gpu driver version: 470.103.01-1
i start a map and it crashes, log from terminal

Unhandled exception. System.ArgumentException: '0' cannot be greater than -0.001.
   at System.Math.ThrowMinMaxException[T](T min, T max)
   at osu.Framework.Graphics.Animations.AnimationClockComposite.get_PlaybackPosition()
   at osu.Framework.Graphics.Video.Video.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
--- End of stack trace from previous location ---
   at osu.Framework.Platform.GameHost.<>c__DisplayClass126_0.<abortExecutionFromException>b__0()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.SDL2DesktopWindow.Run()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at osu.Desktop.Program.Main(String[] args) in /var/lib/buildkite-agent/builds/debian-gnu-linux-vm-2/ppy/osu/osu.Desktop/Program.cs:line 109
[1]    25924 IOT instruction (core dumped)  ./osu.AppImage

Screenshots or videos

No response

Version

2022.319.0-lazer

Logs

database.log
network.log
performance.log
runtime.log

The text was updated successfully, but these errors were encountered:

bdach · 2022-03-19T14:39:11Z

the logs do not contain the crash trace you've pasted in, so you must have started the game after the crash again. we explicitly ask not to do that in the template because the logs are now unusable.

please link the map on which this occurs.

xeome · 2022-03-19T14:41:35Z

im sorry, im updating the logs
the map

enoslayd · 2022-03-19T14:43:18Z

Have you tried to play the map with video turned off?

bdach · 2022-03-19T14:44:12Z

@enoslayd turning video off is not a valid solution. this looks like an actual bug. please do not suggest such things.

xeome · 2022-03-19T14:44:59Z

i have updated the logs on the main issue post
but here they are again:
database.log
network.log
performance.log
runtime.log

xeome · 2022-03-19T14:57:59Z

ok logs didn't include the crash trace again for some reason...
i did it again, these logs include it:
database.log
network.log
performance.log
runtime.log

video showing the crash:

simplescreenrecorder-2022-03-19_17.50.13.mp4

xeome · 2022-03-19T15:10:31Z

any other information needed?

bdach · 2022-03-19T15:13:02Z

i can't reproduce this locally but i think i can see how this can happen. no more info needed thanks.

bdach · 2022-03-19T15:18:25Z

so i'm reasonably sure this is going to boil down to formatContext->duration being negative here:

https://github.com/ppy/osu-framework/blob/cd289a0adafdbe1660446a86719c7436b40f7338/osu.Framework/Graphics/Video/VideoDecoder.cs#L340-L343

@Opelkuh do you know if it is perhaps possible that the aforementioned value is negative? i'm guessing it is -1 in this reported case, leading to a clamp failure multiple layers down the line. i don't think there's anything more intelligent to be done here than fail decoding entirely?

link map for reference, maybe someone else will be able to repro: https://osu.ppy.sh/beatmapsets/1643234#osu/3354107

alikindsys · 2022-03-19T15:41:24Z

can't repro on windows, seems to be platform specific.

bdach · 2022-03-19T15:42:50Z

yes it will be. it's likely to be linux-specific due to use of VDPAU, probably even ffmpeg-version-specific. saying you can't repro when i already said i can't either brings 0 value.

Opelkuh · 2022-03-19T17:53:52Z

The duration can be negative if the video stream doesn't provide it. I don't know if there are video containers that do this but it's the case with e.g. RTSP streams. Stopping decoding in that case is probably the safest bet.

But I'm not sure what's causing it here, the video file does have duration set correctly.

I reprod the crash in osu-framework by hardcoding a RTSP stream as the input:

diff --git a/osu.Framework/Graphics/Video/VideoDecoder.cs b/osu.Framework/Graphics/Video/VideoDecoder.cs
--- a/osu.Framework/Graphics/Video/VideoDecoder.cs	(revision 14ed4f4ac0a05e1ce48ec18d019536ad0262114b)
+++ b/osu.Framework/Graphics/Video/VideoDecoder.cs	(date 1647710347145)
@@ -318,10 +318,10 @@
 
             var fcPtr = ffmpeg.avformat_alloc_context();
             formatContext = fcPtr;
-            formatContext->pb = ioContext;
+            // formatContext->pb = ioContext;
             formatContext->flags |= AGffmpeg.AVFMT_FLAG_GENPTS; // required for most HW decoders as they only read `pts`
 
-            int openInputResult = ffmpeg.avformat_open_input(&fcPtr, "dummy", null, null);
+            int openInputResult = ffmpeg.avformat_open_input(&fcPtr, "rtsp://rtsp.stream/pattern", null, null);
             inputOpened = openInputResult >= 0;
             if (!inputOpened)
                 throw new InvalidOperationException($"Error opening file or stream: {getErrorMessage(openInputResult)}");

bdach · 2022-03-19T22:52:20Z

we may be unable to reproduce due to ffmpeg version differences...

@xeome please post the output of ffmpeg -version on your machine.

smoogipoo · 2022-03-22T00:59:37Z

I can repro the crash.

$ ffmpeg -version
ffmpeg version n5.0 Copyright (c) 2000-2022 the FFmpeg developers
built with gcc 11.2.0 (GCC)
configuration: --prefix=/usr --disable-debug --disable-static --disable-stripping --enable-amf --enable-avisynth --enable-cuda-llvm --enable-lto --enable-fontconfig --enable-gmp --enable-gnutls --enable-gpl --enable-ladspa --enable-libaom --enable-libass --enable-libbluray --enable-libdav1d --enable-libdrm --enable-libfreetype --enable-libfribidi --enable-libgsm --enable-libiec61883 --enable-libjack --enable-libmfx --enable-libmodplug --enable-libmp3lame --enable-libopencore_amrnb --enable-libopencore_amrwb --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-librav1e --enable-librsvg --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libssh --enable-libsvtav1 --enable-libtheora --enable-libv4l2 --enable-libvidstab --enable-libvmaf --enable-libvorbis --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxcb --enable-libxml2 --enable-libxvid --enable-libzimg --enable-nvdec --enable-nvenc --enable-shared --enable-version3
libavutil      57. 17.100 / 57. 17.100
libavcodec     59. 18.100 / 59. 18.100
libavformat    59. 16.100 / 59. 16.100
libavdevice    59.  4.100 / 59.  4.100
libavfilter     8. 24.100 /  8. 24.100
libswscale      6.  4.100 /  6.  4.100
libswresample   4.  3.100 /  4.  3.100
libpostproc    56.  3.100 / 56.  3.100

5.0 seems pretty big (I think 4.0 is the latest supported by o!f right now?)

frenzibyte · 2022-04-02T13:11:50Z

osu!framework seems to run on FFmpeg 4.3.3 as of now, and the issue will probably hide once the proper FFmpeg libraries get shipped with the linux builds (ppy/osu-framework#4349), to then become apparent once we update to FFmpeg 5.0 (ppy/osu-framework#5051).

Perhaps this sort of issue should be bundled within ppy/osu-framework#5051 instead.

huupoke · 2022-04-13T14:38:10Z

A temporary workaround to make video work again, is to override the library loading path to make it use the 4.4 version.
env LD_LIBRARY_PATH=<path_to_ffmpeg_4.4_libraries>:"$LD_LIBRARY_PATH" <path_to_osu_executable>

Arch Linux users can install the ffmpeg4.4 package and set their LD_LIBRARY_PATH to /usr/lib/ffmpeg4.4:"$LD_LIBRARY_PATH"

ThatOneCalculator · 2022-04-14T02:07:21Z

Adding onto this:

Editing line 7 of /usr/share/applications/osu-lazer.desktop to

Exec=env OSU_EXTERNAL_UPDATE_PROVIDER=1 LD_LIBRARY_PATH=/usr/lib/ffmpeg4.4:"$LD_LIBRARY_PATH" /usr/bin/osu-lazer

does the trick really well for launching from a gui menu

itsMapleLeaf · 2022-04-14T03:16:28Z

Adding onto this:

Editing line 7 of /usr/share/applications/osu-lazer.desktop to
Exec=env OSU_EXTERNAL_UPDATE_PROVIDER=1 LD_LIBRARY_PATH=/usr/lib/ffmpeg4.4:"$LD_LIBRARY_PATH" /usr/bin/osu-lazer
does the trick really well for launching from a gui menu

Can confirm, this fixed the issue for me, and also made my videos work again

peppy · 2022-04-21T08:04:06Z

Tracking a fix for this at ppy/osu-framework#4349.

reference: ppy/osu#17345 (comment)

Jordan-Jay · 2022-11-05T10:06:18Z

This issue has been fixed as this map doesn't crash Lazer anymore. 👍

bdach · 2022-11-05T10:44:20Z

That's because we're shipping FFmpeg inside the appimage, as described above. Closing as resolved.

bdach added the missing details Can't move forward without more details from the reporter label Mar 19, 2022

bdach added osu!framework issue Can't resolve this without changes to osu!framework. area:storyboard and removed missing details Can't move forward without more details from the reporter labels Mar 19, 2022

bdach changed the title ~~crash when starting a map~~ Video-relating crashes on some maps due to apparently negative duration Mar 19, 2022

bdach changed the title ~~Video-relating crashes on some maps due to apparently negative duration~~ Video-related crashes on some maps due to apparently negative duration Mar 19, 2022

frenzibyte added the platform/linux label Apr 2, 2022

smoogipoo mentioned this issue Apr 14, 2022

Playing a beatmap with a video crashes on Wayland + AMD GPU #17813

Closed

This comment was marked as off-topic.

Sign in to view

tutacat pushed a commit to tutacat/osu-lazer-bin that referenced this issue Sep 26, 2022

fix crashing on beatmaps with video, pretty PKGBUILD

2a5243f

reference: ppy/osu#17345 (comment)

bdach closed this as completed Nov 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Video-related crashes on some maps due to apparently negative duration #17345

Video-related crashes on some maps due to apparently negative duration #17345

xeome commented Mar 19, 2022 •

edited

Loading

bdach commented Mar 19, 2022

xeome commented Mar 19, 2022

enoslayd commented Mar 19, 2022

bdach commented Mar 19, 2022

xeome commented Mar 19, 2022

xeome commented Mar 19, 2022

xeome commented Mar 19, 2022

bdach commented Mar 19, 2022

bdach commented Mar 19, 2022 •

edited

Loading

alikindsys commented Mar 19, 2022

bdach commented Mar 19, 2022 •

edited

Loading

Opelkuh commented Mar 19, 2022

bdach commented Mar 19, 2022 •

edited

Loading

smoogipoo commented Mar 22, 2022 •

edited

Loading

frenzibyte commented Apr 2, 2022 •

edited

Loading

huupoke commented Apr 13, 2022 •

edited

Loading

ThatOneCalculator commented Apr 14, 2022

itsMapleLeaf commented Apr 14, 2022

peppy commented Apr 21, 2022

This comment was marked as off-topic.

Jordan-Jay commented Nov 5, 2022

bdach commented Nov 5, 2022

Video-related crashes on some maps due to apparently negative duration #17345

Video-related crashes on some maps due to apparently negative duration #17345

Comments

xeome commented Mar 19, 2022 • edited Loading

Type

Bug description

Screenshots or videos

Version

Logs

bdach commented Mar 19, 2022

xeome commented Mar 19, 2022

enoslayd commented Mar 19, 2022

bdach commented Mar 19, 2022

xeome commented Mar 19, 2022

xeome commented Mar 19, 2022

xeome commented Mar 19, 2022

bdach commented Mar 19, 2022

bdach commented Mar 19, 2022 • edited Loading

alikindsys commented Mar 19, 2022

bdach commented Mar 19, 2022 • edited Loading

Opelkuh commented Mar 19, 2022

bdach commented Mar 19, 2022 • edited Loading

smoogipoo commented Mar 22, 2022 • edited Loading

frenzibyte commented Apr 2, 2022 • edited Loading

huupoke commented Apr 13, 2022 • edited Loading

ThatOneCalculator commented Apr 14, 2022

itsMapleLeaf commented Apr 14, 2022

peppy commented Apr 21, 2022

This comment was marked as off-topic.

Jordan-Jay commented Nov 5, 2022

bdach commented Nov 5, 2022

xeome commented Mar 19, 2022 •

edited

Loading

bdach commented Mar 19, 2022 •

edited

Loading

bdach commented Mar 19, 2022 •

edited

Loading

bdach commented Mar 19, 2022 •

edited

Loading

smoogipoo commented Mar 22, 2022 •

edited

Loading

frenzibyte commented Apr 2, 2022 •

edited

Loading

huupoke commented Apr 13, 2022 •

edited

Loading