Custom HP threshold for fade playfield to red when health is low

[gagahpangeran]

Describe the new feature:

Currently the red overlay is start to fade when HP is very low. It will be nice if user can adjust the HP threshold. The minimum value is 0% (disabled) until 50% of HP.

Proposal designs of the feature:

Slider in setting from 0 to 50, value 0 for disabled it.

[bdach]

Personally disagree with having this as a setting on principle of keeping setting count as low as possible.

[Game4all]

It doesn't really make sense (at least to me) to have the ability to set the health threshold at which the layer should start fading in. Since the threshold is hardcoded as a constant

osu/osu.Game/Screens/Play/HUD/FailingLayer.cs

Line 37 in fb5a54d

private const double low_health_threshold = 0.20f;

maybe it should just be changed to something a bit more higher if it was deemed too low?

[gagahpangeran]

It doesn't really make sense (at least to me) to have the ability to set the health threshold at which the layer should start fading in. Since the threshold is hardcoded as a constant

osu/osu.Game/Screens/Play/HUD/FailingLayer.cs

Line 37 in fb5a54d

private const double low_health_threshold = 0.20f;

maybe it should just be changed to something a bit more higher if it was deemed too low?

That constant can be changed to variable and the value is from settings.