Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taiko Visual Full Combo Is Impossible With Spinners #1269

Open
TomyDoesThings opened this issue Dec 9, 2024 · 0 comments
Open

Taiko Visual Full Combo Is Impossible With Spinners #1269

TomyDoesThings opened this issue Dec 9, 2024 · 0 comments

Comments

@TomyDoesThings
Copy link

TomyDoesThings commented Dec 9, 2024

With ppy/osu-web#11697 being fixed, the only remaining issue regarding max combo that I see is full combos not being possible in Taiko if there is at least 1 spinner present. This is a stable client only issue. This may be nitpicky, but when it comes to medals/achievements and defining full combos, an FC at all being inconsistent can create confusion, and even when trying to define full combo on wiki, this was an issue that was stumbled into (ppy/osu-wiki#10285), so much so that no progress was able to be made on it. One beatmapset neatly shows this issue I am presenting.

https://osu.ppy.sh/beatmapsets/774406#taiko/1628575 (circles with 1 spinner) - Impossible to get Perfect in Default Skin to appear on score results (regardless of full combo).
https://osu.ppy.sh/beatmapsets/774406#taiko/1628413 (circles with 1 slider) - Perfect in Default skin appears on score results if full combo.
https://osu.ppy.sh/beatmapsets/774406#taiko/1628414 (only circles) - Perfect in Default skin appears on score results if full combo.

Also, just to ensure no confusion, downloading a replay from online that is marked as a green full combo would not create this issue because that boolean was presumably fixed server-side. This bug is exclusive to the local Taiko scores created in the osu! stable client, so a good way of testing this is to use Auto on particular Taiko maps that have a certain amount of circles, sliders, and especially spinners in this client.

I tested this both in Cutting Edge b20241204 and stable b20241030 and both showcase this same behavior.

My theory is that spinners are accounted for in max combo internally for some reason and that the solution would be to only count circles for max combo, not spinners too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant