Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping connection from spectator server mid-play results in truncated online replay #244

Open
rvneXe opened this issue Sep 19, 2024 · 4 comments
Assignees

Comments

@rvneXe
Copy link

rvneXe commented Sep 19, 2024

Hi. I've downloaded a replay file from my profile to send it for someone, but it displays only a few seconds 'till the end.
This zip file contains the original replay file, which game client gave me. And the replay file which I downloaded from osu.ppy.sh website.
replayfiles.zip

@peppy peppy self-assigned this Sep 27, 2024
@peppy peppy transferred this issue from ppy/osu-web Oct 4, 2024
@peppy
Copy link
Member

peppy commented Oct 4, 2024

The replay retrieved from web contains frames from 658 frames from 141,060 to 152,154 ms, towards the latter end of the beatmap.

This implies the saved replay was truncated. Likely a failed connection to osu-server-spectator.

I'm not sure how we should be handling this yet. Either the whole play should be invalidated, or maybe the client needs to send catch-up data. (low priority cc/ @bdach for visibility on this).

@smoogipoo
Copy link
Contributor

We could probably send the whole replay again after completion for validation?

@bdach
Copy link
Collaborator

bdach commented Oct 4, 2024

I swear I've seen this reported somewhere already and even recall reproducing a connection drop-out doing this but I can't find it now. Maybe a github account deletion sent it to the shadow realm.

@bdach bdach changed the title Downloaded replay file is randomly broken Dropping connection from spectator server mid-play results in truncated online replay Oct 4, 2024
@peppy
Copy link
Member

peppy commented Oct 4, 2024

We could probably send the whole replay again after completion for validation?

Maybe yeah. It's not a high prio item since this should happen quite rarely, but requires some discussion on validation concerns (ie. whether we want to use real-time packets as score validation piece).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants