Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test: fix tests for ubuntu 24 #6038

Merged
merged 1 commit into from
Jan 17, 2025
Merged

E2E test: fix tests for ubuntu 24 #6038

merged 1 commit into from
Jan 17, 2025

Conversation

testlabauto
Copy link
Contributor

Various fixes related to the upgrade of our CI runners to Ubuntu 24:

  • Don't install Python 3.10
  • Use Python 3.12 for tests
  • Provide --no-sandbox param for integration tests
  • Alter App Armor to allow Playwright to launch Electron
  • Stop using pydataset because of problems installing it

Fix related to upstream merge

  • update plot base images

QA Notes

All tests should pass.

Copy link

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@midleman
Copy link
Contributor

midleman commented Jan 17, 2025

Thank you for tackling this to unblock PRs! I would definitely anticipate that the windows workflow is going to need some updates too...

@testlabauto
Copy link
Contributor Author

Thank you for tackling this to unblock PRs! I would definitely anticipate that the windows workflow is going to need some updates too...

Yeah, I have full test running, too. Looks like this one is passed now, but I will update once full test is done.

Copy link
Contributor

@jonvanausdeln jonvanausdeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Once things are working in main again. We should test this against the web e2e tests as well

@testlabauto testlabauto merged commit 25fcbfb into main Jan 17, 2025
11 of 14 checks passed
@testlabauto testlabauto deleted the cmead/fix-ci-for-tests branch January 17, 2025 19:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants