Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Editor Action Bar for Data Explorer #5361

Closed
juliasilge opened this issue Nov 13, 2024 · 1 comment
Closed

Use new Editor Action Bar for Data Explorer #5361

juliasilge opened this issue Nov 13, 2024 · 1 comment
Assignees
Labels
area: editor Issues related to Editor category. area: top bar Issues related to Top Bar category.

Comments

@juliasilge
Copy link
Contributor

Our new Editor Action Bar, first introduced in #5181, is provided for all editor tabs; this includes Data Explorer tabs. Currently, the Data Explorer already has its own type of action bar, but this is now a bit much 😆 with the new additional bar:

Image

The existing actions for the Data Explorer should be contributed to the new bar that we have on all editor tabs, and the existing bar should go away.

(This will also be the way that plots in editor tabs will offer richer UI affordances cc @timtmok )

Note

This together with #5360 is probably the minimum feature set for turning this bar on by default instead of off.

@midleman
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2025.02.0 - 71
OS Version(s) : Mac OS

Test scenario(s)

Manually confirmed editor action bar has replaced editor actions in Data Explorer and works as expected.

Link(s) to TestRail test cases run or created:

Adding coverage for the functionality here: #6019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: editor Issues related to Editor category. area: top bar Issues related to Top Bar category.
Projects
None yet
Development

No branches or pull requests

4 participants