Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If local MFA is configured, and user logs in through GSS, make sure to trigger verification #72

Open
michielbdejong opened this issue Sep 6, 2023 · 2 comments

Comments

@michielbdejong
Copy link
Member

Micke reported that if local MFA is configured, and the user logs in through GSS, verification is not triggered.
So maybe we should trigger it from our app in that case?
Be careful never to trigger verification if MFA is not configured for the current user, because that will (IIUC) lead to the 'token not found' internal server error we saw with some earlier versions of the code.

@michielbdejong
Copy link
Member Author

@mrvahedi68 in your #sitdown message on Slack you said

Need to check how to login from GSS.

-> here it is! https://github.com/pondersource/nextcloud-mfa-awareness/blob/main/servers/setup-gss.sh 🙂

@michielbdejong
Copy link
Member Author

michielbdejong commented Dec 14, 2023

This was now also implemented by
https://github.com/SUNET/nextcloud-stepupauth/releases/tag/v0.2.0
although I have to code it into the Dockerfile and init script and look into #68.

michielbdejong added a commit that referenced this issue Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant