Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App window not shown #97

Open
lineardraft opened this issue Feb 21, 2022 · 6 comments
Open

App window not shown #97

lineardraft opened this issue Feb 21, 2022 · 6 comments
Labels
blocked PR/ISSUE is blocked by third party NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@lineardraft
Copy link

What happened?

If 'Pomerium Desktop' window is closed (not minimized) on macOS, next time when you try open the app from the dock nothing happens.

What did you expect to happen?

The application to present it's window.

How'd it happen?

  1. Clicked (x) close button on window
  2. Window was closed, but theee app is still active
  3. Clicked on icon on the dock
  4. No window presented

What's your environment like?

  • Pomerium Desktop version: 0.16.2
  • Server Operating System/Architecture/Cloud: macOS Monterey 12.2.1

Config export

No connections, fresh install

Additional context

Add any other context about the problem here.

@travisgroth travisgroth added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 22, 2022
@nhayfield
Copy link
Collaborator

There is code to handle this so I am surprised it is not working:

app.on('activate', async () => { // On macOS it's common to re-create a window in the app when the // dock icon is clicked and there are no other windows open. if (mainWindow === null) mainWindow = createWindow(); });

@travisgroth
Copy link
Contributor

We need to confirm from Apple's guidelines but, from discussion, we should be able to remove ourselves from the dock when the window is closed since we have a system tray icon. That would more closely match behavior from other background apps like docker desktop or bitwarden.

@lineardraft could you confirm that when you say "clicked on icon on the dock", you mean this dock menu, correct?

@nhayfield
Copy link
Collaborator

https://www.macworld.com/article/220375/why-some-apps-belong-in-the-menu-bar-not-the-dock.html

Based on the above article, it seems to indicate that for system tray icon menu utility apps, it is better to not show the app in the dock at all.

@nhayfield nhayfield mentioned this issue Mar 1, 2022
6 tasks
@travisgroth
Copy link
Contributor

https://www.macworld.com/article/220375/why-some-apps-belong-in-the-menu-bar-not-the-dock.html

Based on the above article, it seems to indicate that for system tray icon menu utility apps, it is better to not show the app in the dock at all.

That makes sense to me

@calebdoxsey
Copy link
Collaborator

I looked at this but wasn't able to figure out the behavior of the dock in a consistent way or how to customize it.

@calebdoxsey calebdoxsey added the blocked PR/ISSUE is blocked by third party label Apr 13, 2022
@nhayfield
Copy link
Collaborator

it is weird. none of the ways that are supposed to work do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PR/ISSUE is blocked by third party NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants