Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_link_by_name should probably accept OsString not str #19

Open
ArcaneNibble opened this issue Feb 20, 2017 · 1 comment
Open

get_link_by_name should probably accept OsString not str #19

ArcaneNibble opened this issue Feb 20, 2017 · 1 comment

Comments

@ArcaneNibble
Copy link

It is possible to create network device names that are invalid UTF-8 that this crate will not be able to refer to.
@sp3d
Copy link
Contributor

sp3d commented Feb 24, 2019

Arguably the most correct type to accept is a std::ffi::Cstr, which doesn't have Windows-induced recalcitrance around yielding bytes and which should enforce the no-internal-NULs invariant that I believe is present here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArcaneNibble @sp3d