Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrutinizer CI #37

Open
4 tasks
cfoellmann opened this issue Sep 2, 2018 · 0 comments
Open
4 tasks

Scrutinizer CI #37

cfoellmann opened this issue Sep 2, 2018 · 0 comments

Comments

@cfoellmann
Copy link
Collaborator

cfoellmann commented Sep 2, 2018 •
edited
Loading

Analysis by Scrutinizer CI is not perfect, yet.
These is the list of issues:

  • missing comma after last item in array - not detected

  • Method name "PodloveSubscribeButton::load_translations" is not in camel caps format WRONG -> function/method should use underscores!

  • SPACES: array( $variable ) vs array('item') --- really?

  • empty line before function closing -- wrong
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cfoellmann