httpS server seems to not work in v1.14

[omerbrandis]

upgraded my existing application to use poco 1.14 with openssl 3.0.15
when using firefox to get a page from the server over ssl it shows a "SSL_ERROR_RX_RECORD_TOO_LONG" error.
chorme did not show an error msg, but was unable to render, it looks like it kept retrying to get the page.

when using poco 1.13.3 application works.

[micheleselea]

SSL_ERROR_RX_RECORD_TOO_LONG this usually happen if you try to connect to an https on a server that is http.
So probably your problem is that is failing the creation of ssl context to create ssl server socket, check if conext is created correctly

[matejk]

@omerbrandis , does the comment from @micheleselea explain the failure that you reported.

[omerbrandis]

Hello matejk & micheleselea

as i've mentioned before, i did not change my code/configuration, only the linkage to v1.14.
there are no error messages.

• I'm not really sure what micheleselea suggested I check
  ( Poco::Net::HTTPServer::start returns void, the Poco::Net::SecureServerSocket was also created succsesfully, otherwise I would not have gotten to HTTPServer::start & my Request Handlers are called)

• i tried curl -k ...
  got : curl: (56) GnuTLS recv error (-15): An unexpected TLS packet was received.

:-)

[matejk]

Thank you, @omerbrandis. Can you provide a sample code that demonstrates the problem?

[omerbrandis]

Hello Matejk,

I've tried to reproduce the error using simpler code , i've taken the example provided at https://pocoproject.org/ (made the changes required for serving over ssl), the error did not reproduce.

i've then taken the next step, it seems the error is in method HTTPServerResponse::sendFile,
it does not throw an exception, but it does not work as expected
see attached.

main.txt

I'm not really sure how to debug this further....
:-)

[d3matt]

I'm pretty sure it's the changes to HTTPServerResponseImple.cpp in commit 710c2a4. I don't think you can use sendFile with a TLS connection. I reverted just that file and HTTPServerResponse::sendFile is working again as expected for me over a TLS connection.

[d3matt]

FWIW: our index.html (1353 bytes) was able to get served correctly but our favicon.ico (3902 bytes) would trigger the record too long error.

[obiltschnig]

Hm, sendfile() definitely will not work with a TLS connection. That whole implementation needs to be redesigned to make it work.

[micheleselea]

mmm I don't get it, I usually use Poco::Net::HTTPServerResponse::sendFile() without problem, I don't think we need to use SocketImpl::sendFile() in a HTTPS server