Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLChannel stops logging on LoggingSubsystem shutdown #4529

Open
3 tasks done
aleks-f opened this issue Apr 13, 2024 · 1 comment
Open
3 tasks done

SQLChannel stops logging on LoggingSubsystem shutdown #4529

aleks-f opened this issue Apr 13, 2024 · 1 comment
Assignees
@matejk @aleks-f
Labels
bug feature
Milestone
Release 1.14.0

Comments

@aleks-f
Copy link
Member

aleks-f commented Apr 13, 2024 •
edited
Loading

Describe the bug

  • last log messages not logged on shutdown
  • code after main while loop in run is never reached (thread abruptly terminated?)
  • feature: add store-and-forward mode
@aleks-f aleks-f added the bug label Apr 13, 2024
@aleks-f aleks-f added this to the Release 1.14.0 milestone Apr 13, 2024
@aleks-f aleks-f self-assigned this Apr 13, 2024
@aleks-f aleks-f added this to 1.14 Apr 13, 2024
aleks-f added a commit that referenced this issue Apr 13, 2024
@aleks-f
enh(SQLLogger): #4529 (wip)
016faef
@matejk
Copy link
Contributor

matejk commented Apr 14, 2024

I get this static analysis warning in SQLChannel dtor:

/poco/Data/src/SQLChannel.cpp:112:3: Call to virtual method 'SQLChannel::close' during destruction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]

matejk added a commit that referenced this issue Apr 14, 2024
@matejk
enh(SQLiteTest): extend unit test to destroy SQL channel while it has…
7fe24c0 
… pending messages. (#4529)
matejk added a commit that referenced this issue Apr 14, 2024
@matejk
enh(SQLiteTest): extend unit test to destroy SQL channel while it has…
54b6e21 
… pending messages. (#4529)
aleks-f added a commit that referenced this issue Jul 15, 2024
@aleks-f
fix(DataTest): SQLChannel *nix build and test run #4529
151882b
aleks-f added a commit that referenced this issue Jul 15, 2024
@aleks-f
fix(DataTest): CodeQL warning #4529
0730fa2
aleks-f added a commit that referenced this issue Jul 16, 2024
@aleks-f
feat(SQLChannel): add flush property #4529
5fc5d7d
aleks-f added a commit that referenced this issue Jul 16, 2024
@aleks-f
enh(SQLChannel): use event for interruptible sleep; reduce code dupli…
32569d8 
…cation with lambda; update comments #4529
aleks-f added a commit that referenced this issue Jul 16, 2024
@aleks-f
fix(SQLChannel): flush time determination #4529
28b42b6
aleks-f added a commit that referenced this issue Jul 16, 2024
@aleks-f @matejk
4529 sql logger shutdown (#4530)
ed181d9 
* enh(ThreadTest): add join test

* enh(SQLLogger): #4529 (wip)

* enh(SQLChannel): just few C++17 modernisations.

* enh(SQLiteTest): extend unit test to destroy SQL channel while it has pending messages. (#4529)

* enh(ODBC): improve exception descriptions and add string/batch size tests

* feat(SQLChannel): add store-and-forward mode

* fix(DataTest): SQLChannel *nix build and test run #4529

* fix(DataTest): CodeQL warning #4529

* chore(ODBCTest): lower the number of max statements in big batch

* feat(SQLChannel): add flush property #4529

* enh(SQLChannel): use event for interruptible sleep; reduce code duplication with lambda; update comments #4529

* fix(SQLChannel): flush time determination #4529

---------

Co-authored-by: Matej Kenda <[email protected]>
@aleks-f aleks-f moved this to Done in 1.14 Jul 30, 2024
@aleks-f aleks-f moved this from Done to In Progress in 1.14 Oct 14, 2024
@aleks-f aleks-f moved this from In Progress to Done in 1.14 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejk matejk

@aleks-f aleks-f

Labels
bug feature
Projects
1.14
Status: Done
Milestone
Release 1.14.0
Development

No branches or pull requests
2 participants
@matejk @aleks-f