Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving spo homesite commands to spo tenant homesite #6502

Open
milanholemans opened this issue Nov 24, 2024 · 4 comments · May be fixed by #6531
Open

Moving spo homesite commands to spo tenant homesite #6502

milanholemans opened this issue Nov 24, 2024 · 4 comments · May be fixed by #6531
Assignees
@milanholemans
Labels
enhancement work in progress

Comments

@milanholemans
Copy link
Contributor

milanholemans commented Nov 24, 2024 •
edited
Loading

Since spo homesite commands are all using SharePoint administration APIs for which you have to be a SharePoint administrator, I wonder if we should deprecate them and rename them to spo tenant homesite.
In this case we should add spo homesite as alias for the new commands and remove them in the next major release.

Todo: create v11 issue to remove the old aliases.
@milanholemans milanholemans added enhancement needs peer review Needs second pair of eyes to review the spec or PR labels Nov 24, 2024
@milanholemans
Copy link
Contributor Author

What do you think @pnp/cli-for-microsoft-365-maintainers?

@milanholemans milanholemans mentioned this issue Nov 24, 2024
Closed
@Adam-it
Copy link
Member

Adam-it commented Nov 27, 2024

sounds good to me.
Sorry for the late response 🙏

@milanholemans
Copy link
Contributor Author

milanholemans commented Nov 27, 2024 •
edited
Loading

sounds good to me. Sorry for the late response 🙏

3 days is a decent response time if you ask me @Adam-it 😊
Thanks for checking this issue 🙏

@milanholemans milanholemans added help wanted and removed needs peer review Needs second pair of eyes to review the spec or PR labels Nov 27, 2024
@milanholemans milanholemans self-assigned this Dec 19, 2024
@waldekmastykarz
Copy link
Member

Agreed

milanholemans added a commit to milanholemans/cli-microsoft365 that referenced this issue Dec 22, 2024
@milanholemans
Renames 'spo homesite' commands to 'spo tenant homesite'. Closes pnp#…
adc5fd6 
…6502
This was referenced Dec 22, 2024
Open
Open
milanholemans added a commit to milanholemans/cli-microsoft365 that referenced this issue Dec 22, 2024
@milanholemans
Renames 'spo homesite' commands to 'spo tenant homesite'. Closes pnp#…
f397221 
…6502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milanholemans milanholemans

Labels
enhancement work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renames spo homesite commands to spo tenant homesite milanholemans/cli-microsoft365
3 participants
@waldekmastykarz @milanholemans @Adam-it