Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: HiOp 1.0.1+ suport #80

Closed
5 tasks
cameronrutherford opened this issue Nov 21, 2023 · 4 comments · Fixed by #84
Closed
5 tasks

meta: HiOp 1.0.1+ suport #80

cameronrutherford opened this issue Nov 21, 2023 · 4 comments · Fixed by #84
Assignees

Comments

@cameronrutherford
Copy link
Contributor

There are many moving parts here, and so I am creating a new issue to track all these components, and to determine the right order to operations.

Here are the current list of relevant issues (with related PRs):

We will likely need a larger PR to address all of these issues somehow, but the hope is that they can all be resolved together.

@nychiang
Copy link
Collaborator

@cameronrutherford should I try to use the latest develop branch, or release 1.6.0?

@cameronrutherford
Copy link
Contributor Author

@cameronrutherford should I try to use the latest develop branch, or release 1.6.0?

We will need some patches merged into ExaGO to fix this, so definitely develop. We will then have a PR with working changes + latest HiOp running tests on all platforms

@jaelynlitz jaelynlitz mentioned this issue Nov 21, 2023
20 tasks
@nychiang
Copy link
Collaborator

@jaelynlitz @cameronrutherford I filed a new PR in HiOp, to withdraw -Wall and -Werror in the RELEASE mode.
Therefore, I expect this can fix the compile warnings/errors you observed with unused variables.

@cameronrutherford
Copy link
Contributor Author

cameronrutherford commented Nov 29, 2023

@jaelynlitz just got back from vacation and is leading this, but that is helpful. We will generate new build with that PR and hopefully we can then re-add develop builds of hiop back with ExaGO.

We also need LLNL/hiop#669 merged in order to support #50 and latest Ginkgo release in ExaGO, so we may need to test experimental versions of HiOp in many places at once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants