Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOPFLOW Python Tests re-visit (functionality vs unit tests) #142

Open
2 of 4 tasks
cameronrutherford opened this issue May 7, 2024 · 0 comments
Open
2 of 4 tasks

Comments

@cameronrutherford
Copy link
Contributor

Issue type

  • Bug

Relates to

  • SOPFLOW

Summary

From this thread on #131, it is clear that SOPFLOW tests run the entire application many times, however these are only functionality tests. We should also ensure unit tests.

There is a comment in the source code that mentions the inability to do this without calling sopflow.setup() or else our destructor segfaults. We should also either:

  • Fix this issue in the destructor, and make sure the correct memory is allocated / freed and the bug is squashed
  • Document this thoroughly, explain why, and make sure users are aware

cc #140 as well since a similar issue was seen there according to @jaelynlitz and @Jayapreethi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant