Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Support containers with health checks #20

Open
petersem opened this issue Jun 30, 2021 · 6 comments
Open

Enhancement: Support containers with health checks #20

petersem opened this issue Jun 30, 2021 · 6 comments

Comments

@petersem
Copy link

With healthcheck support, will show status of starting/healthy/unhealthy

@Inlustra
Copy link
Collaborator

Inlustra commented Jul 1, 2021

Specifically talking about the docker connector, it already does this if you've configured your containers correctly in Docker as Plugsy just grabs the docker status using the docker API

@Inlustra
Copy link
Collaborator

Inlustra commented Jul 1, 2021

Now I might have missed a status or two but you should see those in the logs

@petersem
Copy link
Author

petersem commented Jul 1, 2021

@Inlustra I use health checks a lot, but everything is just showing as running. probably 60-70% of mine have health checks though.
list

@Inlustra
Copy link
Collaborator

Inlustra commented Jul 1, 2021

Ahh that's cool, I realise the difference now, thanks for pointing that out, I'll take a look when I get some time!

@petersem
Copy link
Author

petersem commented Jul 1, 2021

@Inlustra btw, i also did a post on Plugsy in my docker group on FB. (550+ users 'Dockerholics'), so you may see a spike in uptake today :) Thanks again for your efforts.

@Inlustra
Copy link
Collaborator

6 months later, we're getting an update on this, it is very barebones.

If your container has a health status (As per the Docker API) it will be shown. But that's not reflected in the color of the icon, it should match up automatically due to default docker statuses though.

If you have some time, I'd love some feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants