Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to check in/out permissions #67

Open
rpatterson opened this issue Feb 20, 2019 · 2 comments
Open

Switch to check in/out permissions #67

rpatterson opened this issue Feb 20, 2019 · 2 comments

Comments

@rpatterson
Copy link
Member

IIUC, plone.app.iterate defines plone.app.iterate.CheckOutContent and plone.app.iterate.CheckInContent permissions but nothing uses them. The @@iterate_control view doesn't check any permission on checkout but zope2.View and manually checks cmf.ModifyPortalContent in Python on checkin. This means it's not possible for a project that requires customizing the check in/out policy, such as one that wants to allow users who can't edit the original content to be able to review and approve checkouts, to do so without overriding the control view and repeating a bunch of conditions.

IMO, the @@iterate_control view should check the currently unused plone.app.iterate.CheckOutContentandplone.app.iterate.CheckInContent` permissions and not use the core CMF permissions.

@djay
Copy link
Member

djay commented Feb 21, 2019

Could help with the issue in #59 which is really about enforcing a review process and disallowing the ability to edit a published object. You would have to adjust the workflow so published state removes the edit permission and adds a checkout permission instead.

@rpatterson
Copy link
Member Author

Will someone review #68?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants