Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

likely to be hidden when using diazo themes #7

Open
djay opened this issue Jan 16, 2012 · 4 comments
Open

likely to be hidden when using diazo themes #7

djay opened this issue Jan 16, 2012 · 4 comments

Comments

@djay
Copy link
Member

djay commented Jan 16, 2012

Normally when you write a diazo theme you tend to include the viewlet managers explicitly via the rules file. Since the debug toolbar provides its own viewlet manager it's unlikely to be visible from the diazo themed site, so you have to turn off the diazo theme to view it.
I'm not sure the best way to fix this. Perhaps if it used one of the standard viewlet managers and then js or css to position itself at the top of the page?

@djay
Copy link
Member Author

djay commented Jan 16, 2012

It would be even more convinient if the toolbar could be accessed without having to install it but I can't see how this can be achieved.
The reason for this, is then it can be used on a single instance that includes the extra egg, even if the same database is shared with other instances that don't have the p.a.toolbar egg. For instance this extra instance could be a manually started instance just for debugging purposes.

@fgrcon
Copy link
Member

fgrcon commented Nov 13, 2012

I just added

        <before css:theme="#portal-top" css:content="#debug-toolbar-trigger" /> 
        <before css:theme="#portal-columns-wrapper" css:content="#debug-toolbar" />

to my rules.xml and can see it in my diazo themed development site ....

@idgserpro
Copy link

I just came by this issue: plone.app.debugtoolbar wasn't showing up, I was thinking about an error in the package but in the end was in the diazo architecture.

The solution provided by @fgrcon indeed works, but I don't agree in adding a new rule since this is only used in development, not in production.

I suggest a pragmatic approach: improve documentation in how to use plone.app.debugtoolbar saying that the Debug link doesn't work out of the box if you're using Diazo, since you need to add it to rules.xml. Please give the following hint as well: you can use ?diazo.off=1 (ref: https://github.com/plone/plone.app.theming/blob/81522bb6eb2bf55d3ef0c14c297014a821b12099/src/plone/app/theming/browser/resources/userguide.rst#theme-debugging) to disable diazo. You should see the "Debug" link.

I would do a PR myself but I'm not so sure if it's ok here in the plone namespace since we don't have a Contributor's Agreement (but have permission to add documentation). @polyester can you help us here? Is this the same situation as https://community.plone.org/t/transactions-between-robot-tests-how-and-where-to-document/6831/4?

@polyester
Copy link
Member

I'd say you are fine to do a PR as long as it's in the documentation of this package. For code, it would be more difficult, but for documentation just make the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants