-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
likely to be hidden when using diazo themes #7
Comments
It would be even more convinient if the toolbar could be accessed without having to install it but I can't see how this can be achieved. |
I just added <before css:theme="#portal-top" css:content="#debug-toolbar-trigger" />
<before css:theme="#portal-columns-wrapper" css:content="#debug-toolbar" /> to my rules.xml and can see it in my diazo themed development site .... |
I just came by this issue: plone.app.debugtoolbar wasn't showing up, I was thinking about an error in the package but in the end was in the diazo architecture. The solution provided by @fgrcon indeed works, but I don't agree in adding a new rule since this is only used in development, not in production. I suggest a pragmatic approach: improve documentation in how to use plone.app.debugtoolbar saying that the I would do a PR myself but I'm not so sure if it's ok here in the plone namespace since we don't have a Contributor's Agreement (but have permission to add documentation). @polyester can you help us here? Is this the same situation as https://community.plone.org/t/transactions-between-robot-tests-how-and-where-to-document/6831/4? |
I'd say you are fine to do a PR as long as it's in the documentation of this package. For code, it would be more difficult, but for documentation just make the PR. |
Normally when you write a diazo theme you tend to include the viewlet managers explicitly via the rules file. Since the debug toolbar provides its own viewlet manager it's unlikely to be visible from the diazo themed site, so you have to turn off the diazo theme to view it.
I'm not sure the best way to fix this. Perhaps if it used one of the standard viewlet managers and then js or css to position itself at the top of the page?
The text was updated successfully, but these errors were encountered: