Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use pre-commit / husky / plone/meta in a monorepo #5

Open
ericof opened this issue May 13, 2024 · 3 comments
Open

How to use pre-commit / husky / plone/meta in a monorepo #5

ericof opened this issue May 13, 2024 · 3 comments
Labels

Comments

@ericof
Copy link
Member

ericof commented May 13, 2024

Nowadays we have two different approaches to lint/formatting backend codebases:

  • Addons: Usage of plone/meta
  • Monorepos: Usage of Docker-based Code Quality

We want to unify this behavior, but:

  • pre-commit (used by plone-meta) does not support monorepos
  • husky focuses mostly on frontend
  • Code Quality focuses mostly on the backend

So, we should discuss how to solve this

@ericof
Copy link
Member Author

ericof commented May 15, 2024

Article about a tool that would allow us to use pre-commit with a monorepo.

@ericof ericof moved this to Backlog in Beethoven Sprint 2024 May 15, 2024
@ericof
Copy link
Member Author

ericof commented May 15, 2024

@gforcada, @fredvd

@fredvd
Copy link
Member

fredvd commented May 15, 2024

We discussed this at the Beethoven sprint, also about the politics behind the current offerings .I'm mostly responding from the perspective of how much work and ongoing maintenance will choosing a direction mean for us:

The main team supporting/maintaining precommit actively disapproves of any support for monorepo's, although many users would like this, so the plugin is actually patching precommit and could require some support from our community in the future.

An alternative would be add some tooling to wrap precommit and let it run on the packages, mentioned by @davisagli , and is from a coding perspective less risky, but could need more support and we'll have to 'own' the wrapper.

Not using pre-commit but looking for another alternative would not solve the issue to have one setup to 'rule them all', or we would have to change plone meta as well, which will be even more work. Where plone meta seems to do a large part of the job currently (for the backend) and uses one of the most 'popular' tools, precommit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants