-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedburner post does not contain author #139
Comments
The problem with the author is due to the default Hugo RSS template using the Site.Author parameter which we have not set. I have created a site default RSS template in 4ebe2fe which uses the post's Author information to fill the |
The duplicate image issue is caused by using the In the RSS feed both images are displayed because the There are a few options for fixing this that I can see:
In the interest of time I have chosen option 3 above for this particular post in 484cdb1. |
@osis I think we might want to reconsider this approach to responsive images, ideally finding a solution that degrades well without CSS, and uses CSS (or javascript?) to make the images present well on any size screen. |
@ihuston does this mean each individual author will now show up in RSS feeds? If so, sweet. |
@tsaleh Yes, the RSS feed should now contain author names:
If you want to link your real email, you can add it in the
|
I can confirm that the individual author name shows up in the RSS feed. However now there is a small but different problem: http://engineering.pivotal.io/categories/postgresql/ In addition to that, would be nice if the author name on article pages is a link too. |
@andreasscherbaum, there shouldn't be any links in the RSS feed itself. The
Where are you seeing this link? Perhaps it would be better to open another more specific issue and provide an example there. On the article pages, the author is linked to their Twitter account if provided in the author file, e.g. |
@ihuston I'm not talking about the RSS feed, but the change has some fallout. Just follow the link I posted: http://engineering.pivotal.io/categories/postgresql/ And klick on any author name. |
Hi Andreas,
Would it be possible for you to make this fix yourself, since you seem to
understand the problem more?
On Tue, Mar 28, 2017 at 11:11 AM Andreas Scherbaum ***@***.***> wrote:
@ihuston <https://github.com/ihuston> I'm not talking about the RSS feed,
but the change has some fallout. Just follow the link I posted:
http://engineering.pivotal.io/categories/postgresql/
And klick on any author name.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#139 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAH4Fk1kDFRxfFM303wOu5xUD7QsYQ6ks5rqU1NgaJpZM4MSG-G>
.
--
Cheers, Tammer Sent from my iPhone.
|
Me, dive into the strange template code again? Uhm, ok ... |
It's surprising to me that changing the RSS template could have any effect
on the normal pages.
First step might be to locally pull the commit before my change above and
confirm the problem goes away.
…On Tue, 28 Mar 2017, 19:56 Andreas Scherbaum, ***@***.***> wrote:
Me, dive into the strange template code again?
Uhm, ok ...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#139 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABQtfJKpGShKE2q8LS5SV80P1WQ2m_vSks5rqVfFgaJpZM4MSG-G>
.
|
@andreasscherbaum Is the links issues fixed with your new author pages? I can't see any rogue links in the feeds as it is today. Also the I would suggest that we adjust to name strings only, which is what most other publications do. Also, I feel like we're talking about a few different issues here. Let me try to split this up a bit... Duplicate Images (#150) |
Just checked, the author does not show up (for my post) here: http://feeds.feedburner.com/PivotalEngineeringJournal That's strange, I remember that last time I checked the email address showed up. |
I'm not sure how much I trust feedburner to validate. I don't see authors on other publications as well. http://feeds.feedburner.com/businessinsider/science Authors do show up for me in Feedly, which is good enough for me at this point. I still feel like we should tweak the formatting to be in line with others. |
If you look at the posting from @ihuston from end of March, there was the author information in it. Why is it gone now? |
Oh, I think he was looking at the feed itself instead of Feedburner. http://engineering.pivotal.io/index.xml I see authors in this raw rss feed. Correction |
Hmmmm this might leave out people who don't have twitter like https://github.com/pivotal/blog/blob/master/data/authors/ssmith.yml. Let's put this particular issue to bed since it seems to be solved. |
You might be able to place this information in the header of the article, as comments. But I'm not sure if IFTTT can extract it from there. |
The Feedburner feed seems to ignore the author field and duplicates any images in the post. This is a problem because the main Pivotal content site has started to pick up posts from the Engineering blog and repost them.
See for example this post which appears on the main Pivotal blog without author attribution.
The picture in the post is also duplicated in the Feedburner item and main Pivotal blog:
Looking at the XML feed the author does not appear in the item header:
The text was updated successfully, but these errors were encountered: