Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word wrap #56

Open
jcubic opened this issue Jul 21, 2020 · 4 comments
Open

Word wrap #56

jcubic opened this issue Jul 21, 2020 · 4 comments

Comments

@jcubic
Copy link

jcubic commented Jul 21, 2020

I use you library as demo for jQuery Terminal and it seems that it don't wrap word properly,

type this:

echo There is in the worst of fortunes the best change of a happy ending. | say

the output is:

 __________________________________________
/ There is in the worst of fortunes the be \
\ st change of a happy ending.             /
 ------------------------------------------
        \   ^__^
         \  (oO)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

but native cowsay prints:

 _______________________________________
/ There is in the worst of fortunes the \
\ best change of a happy ending.        /
 ---------------------------------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||

As you can see best is never broken into two words. If you will accept PR I can check if I can fix this.

@jcubic
Copy link
Author

jcubic commented Jun 10, 2021

It's been almost a year and no even a single comment. Do you accept PR?

@MarketingPip
Copy link

@jcubic - did you every make a fix for this? It also seems to mess up due to string-width library not detecting ANSI codes. (Which it can when set).

@jcubic
Copy link
Author

jcubic commented Sep 10, 2024

No, I was not even checking the code.

@MarketingPip
Copy link

@jcubic - fair enough. If you ever take a jab at this do lmk.

ps; I made a pr on the lolcat module you published. Would love to work with you on something / together in future. As my library is heavily inspired by yours in my organization. ie; Termino.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants