Scrape categories and topics for news.py
#215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace existing hard-coded news categories and topics with helper functions that scrape these values. The values are scraped when the user calls a function from the news module for the first time, and the scraped values are reused in all subsequent function calls.
Rewrite news.py to cache categories and topics using the functools @cache decorator rather than global variables
RitwikGupta
reviewed
Dec 25, 2024
Pipfile.lock
Outdated
There was a problem hiding this comment.
Are these version changes needed? You bump up the minimum Python version
There was a problem hiding this comment.
Most of them aren't necessary, but the jinja2 version change is necessary as a security update (the repo current has 4 Dependabot alerts for security vulnerabilities in the current jinja2 version). I had simply run pipenv update when I was making my changes for this PR.
There was a problem hiding this comment.
Make the dependency changes in a different PR
|
|
||
| topics = news.get_topics() | ||
|
|
||
| self.assertCountEqual( |
There was a problem hiding this comment.
Is this test going to hold true even into the future?
There was a problem hiding this comment.
Yes, all the tests for the news module are mocked. The mock files are in the tests/samples directory.
Revert dependency updates in Pipfile.lock and requirements.txt. The updates will be left for a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204
Replace existing hard-coded news categories and topics with helper functions that scrape these values. The values are scraped when the user calls a function from the news module for the first time, and the scraped values are reused in all subsequent function calls.