Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new added config part in openapi spec #3397

Open
Ehco1996 opened this issue Oct 27, 2021 · 1 comment
Open

add new added config part in openapi spec #3397

Ehco1996 opened this issue Oct 27, 2021 · 1 comment
Assignees
@WizardXiao
Labels
area/dm Issues or PRs related to DM. subject/new-feature Denotes an issue or pull request adding a new feature.

Comments

@Ehco1996
Copy link
Contributor

Ehco1996 commented Oct 27, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe

will introduce some new config field in TaskConfig so we need also update the openapi spce, the list is

  • timezone
  • compact
  • mutiple_rows
  • collation_compatible

Describe the feature you'd like

add need field in openapi spce and change the adapter logic in https://github.com/pingcap/dm/blob/master/dm/config/task_converters.go

Describe alternatives you've considered

none

Teachability, Documentation, Adoption, Migration Strategy

none
@Ehco1996 Ehco1996 transferred this issue from pingcap/dm Nov 11, 2021
@Ehco1996 Ehco1996 added the area/dm Issues or PRs related to DM. label Nov 11, 2021
@Ehco1996 Ehco1996 self-assigned this Nov 23, 2021
@Ehco1996 Ehco1996 added the subject/new-feature Denotes an issue or pull request adding a new feature. label Nov 23, 2021
@Ehco1996 Ehco1996 mentioned this issue Nov 23, 2021
Closed
14 tasks
@Ehco1996 Ehco1996 mentioned this issue Dec 30, 2021
Merged
@WizardXiao
Copy link
Contributor

just to remind, we need add collation_compatible config to OpenAPI, ref #4121

@Ehco1996 Ehco1996 mentioned this issue Jan 11, 2022
Closed
@Ehco1996 Ehco1996 assigned WizardXiao and unassigned Ehco1996 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WizardXiao WizardXiao

Labels
area/dm Issues or PRs related to DM. subject/new-feature Denotes an issue or pull request adding a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

openapi(dm): add more task config field
2 participants
@Ehco1996 @WizardXiao