Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dupdetect: gRPC cancel should trigger retry #58542

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dupdetect: gRPC cancel should trigger retry #58542

wants to merge 2 commits into from
+2 −1

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Dec 26, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58523

Problem Summary:

What changed and how does it work?

gRPC "canceled" error may be caused by network problems, for example the server thinks the client is gone so it cancels the RPC, and then the client receives canceled error, because streaming RPC has 2 connections independently for C->S and S->C. In lightning use case, we only want to break the retry when the user cancels it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 26, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lance6716, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 26, 2024
@tiprow tiprow
Copy link

tiprow bot commented Dec 26, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
remove todo
a75eb2b 
Signed-off-by: lance6716 <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.7397%. Comparing base (9958228) to head (a75eb2b).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58542        +/-   ##
================================================
+ Coverage   73.5134%   73.7397%   +0.2262%     
================================================
  Files          1681       1711        +30     
  Lines        464459     472493      +8034     
================================================
+ Hits         341440     348415      +6975     
- Misses       102157     102526       +369     
- Partials      20862      21552       +690
Flag Coverage Δ
integration 52.1893% <0.0000%> (?)
unit 72.2974% <0.0000%> (+0.0403%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7565% <ø> (-0.0120%) ⬇️

@lance6716
Copy link
Contributor Author

/cc @D3Hunter

@ti-chi-bot ti-chi-bot bot requested a review from D3Hunter December 26, 2024 07:45
D3Hunter
D3Hunter reviewed Dec 26, 2024
View reviewed changes
pkg/lightning/backend/local/duplicate.go
@@ -997,7 +998,7 @@ func (m *dupeDetector) processRemoteDupTask(
}
return nil
}
if log.IsContextCanceledError(err) {
if stderrors.Is(err, context.Canceled) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will err be nested? maybe check ctx.Err() != nil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see https://pkg.go.dev/errors#Is can handle nested error by checking Unwrap interface. However I think check the ctx argument is more direct. I'll check it soon.

@D3Hunter D3Hunter changed the title lightning: gRPC cancel should trigger retry dupdetect: gRPC cancel should trigger retry Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter left review comments

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DDL failed with error failed to create remote duplicate kv stream when TiKV is unstable
2 participants
@lance6716 @D3Hunter