Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instance): remove all group dep from instance controllers #5986

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

liubog2008
Copy link
Member

Avoid get info from the group spec to decouple the group and the instance.

@ti-chi-bot ti-chi-bot bot added the size/XXL label Dec 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 3.57143% with 27 lines in your changes missing coverage. Please review.

Project coverage is 19.87%. Comparing base (aebd8d9) to head (798e50f).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #5986      +/-   ##
==============================================
+ Coverage       19.69%   19.87%   +0.17%     
==============================================
  Files             151      151              
  Lines           10461    10367      -94     
==============================================
  Hits             2060     2060              
+ Misses           8189     8095      -94     
  Partials          212      212              
Flag Coverage Δ
unittest 19.87% <3.57%> (+0.17%) ⬆️

Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2024

@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit a57261a into pingcap:feature/v2 Dec 19, 2024
6 of 7 checks passed
@liubog2008 liubog2008 added the v2 for operator v2 label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL v2 for operator v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants