Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support angular 18 #147

Open
gwentey opened this issue Dec 8, 2024 · 8 comments · May be fixed by #151
Open

Update to support angular 18 #147

gwentey opened this issue Dec 8, 2024 · 8 comments · May be fixed by #151
Labels
enhancement New feature or request

Comments

@gwentey
Copy link

gwentey commented Dec 8, 2024

Currently version 3.1.0 is not working with angular v18.

npm error code ERESOLVE npm error ERESOLVE unable to resolve dependency tree npm error npm error While resolving: [email protected] npm error Found: @angular/[email protected] npm error node_modules/@angular/common npm error @angular/common@"18.2.13" from the root project npm error npm error Could not resolve dependency: npm error peer @angular/common@"14 - 17" from [email protected] npm error node_modules/angular-tabler-icons npm error angular-tabler-icons@"3.1.0" from the root project npm error npm error Fix the upstream dependency conflict, or retry npm error this command with --force or --legacy-peer-deps npm error to accept an incorrect (and potentially broken) dependency resolution. npm error npm error

@pierreavn
Copy link
Owner

Hi, please use latest version of the package:
npm install [email protected]

@gwentey
Copy link
Author

gwentey commented Dec 8, 2024

Hello,
I already tried but the lastest version use : linkedSignal
and it doesn't exist in angular 18

[INFO] ./node_modules/angular-tabler-icons/fesm2022/angular-tabler-icons.mjs:64:16-28 - Error: export 'linkedSignal' (imported as 'linkedSignal') was not found in '@angular/core'

thanks

@molinet
Copy link

molinet commented Dec 8, 2024

Same problem here, none of the 3.X versions work with angular 18 as they all cause that same error.

@demotey
Copy link

demotey commented Dec 9, 2024

Same problem .... Same problem... and I don't know what to do my application in production has been down for 2 days...

@the-ult
Copy link

the-ult commented Dec 10, 2024

Latest version is indeed for angular >= 19
Should have made that more clear.

@pierreavn, should I add this to the readme (and supported versions).
And maybe release a 4.x -> Breaking change?

With Angular 18, you should downgrade.

With 3.1.x you can use the allowVersions in your package.json when using pnpm

For example:

"pnpm": {
    "peerDependencyRules": {
      "allowedVersions": {
        "angular-tabler-icons>@angular/common": "18",
        "angular-tabler-icons>@angular/core": "18"
      }
    }
  },

With npm this should work:

"overrides": {
  "angular-tabler-icons": {
    "peerDependencies": {
      "@angular/common": "18.x",
      "@angular/core": "18.x"
    }
  }
}

Or use npm i --legacy-peer-deps (for now)

@gwentey
Copy link
Author

gwentey commented Dec 10, 2024

Latest version is indeed for angular >= 19 Should have made that more clear.

@pierreavn, should I add this to the readme (and supported versions). And maybe release a 4.x -> Breaking change?

With Angular 18, you should downgrade.

With 3.1.x you can use the allowVersions in your package.json when using pnpm

For example:

"pnpm": {
    "peerDependencyRules": {
      "allowedVersions": {
        "angular-tabler-icons>@angular/common": "18",
        "angular-tabler-icons>@angular/core": "18"
      }
    }
  },

With npm this should work:

"overrides": {
  "angular-tabler-icons": {
    "peerDependencies": {
      "@angular/common": "18.x",
      "@angular/core": "18.x"
    }
  }
}

Or use npm i --legacy-peer-deps (for now)

It works ! thanks

@pierreavn
Copy link
Owner

Latest version is indeed for angular >= 19 Should have made that more clear.

@pierreavn, should I add this to the readme (and supported versions). And maybe release a 4.x -> Breaking change?

With Angular 18, you should downgrade.

With 3.1.x you can use the allowVersions in your package.json when using pnpm

For example:

"pnpm": {
    "peerDependencyRules": {
      "allowedVersions": {
        "angular-tabler-icons>@angular/common": "18",
        "angular-tabler-icons>@angular/core": "18"
      }
    }
  },

With npm this should work:

"overrides": {
  "angular-tabler-icons": {
    "peerDependencies": {
      "@angular/common": "18.x",
      "@angular/core": "18.x"
    }
  }
}

Or use npm i --legacy-peer-deps (for now)

Indeed you right y'all.

I never used npm overrides, @the-ult if you have time, could you do a PR explaining this in README? it would be awesome.

@the-ult
Copy link

the-ult commented Dec 18, 2024

I'll try to make some time during the holidays/vacation.
Add some tests and improve readme

@pierreavn pierreavn added the enhancement New feature or request label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants