Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎛️ Consider adding harvest method to BaseStrategy #11

Open
dantop114 opened this issue Jan 30, 2022 · 0 comments
Open

🎛️ Consider adding harvest method to BaseStrategy #11

dantop114 opened this issue Jan 30, 2022 · 0 comments

Comments

@dantop114
Copy link
Collaborator

A method to harvest a strategy would be desired. At the moment strategies are exposing methods to handle strategies positions. In case of multistep strategies this leads the harvester to fire multiple transactions to harvest a strategy. This is simply boring.

The only technical choice left is if harvest should accept configuration parameters in input. Take for example the BeetsStrategy: staking rewards for staking LP tokens on Beethoven can be used in two ways. How do you split those? Can this split decision be made on a harvest-by-harvest basis?

Having a signature for harvest like harvest(bytes memory payload) seems to be more flexible.
Having a signature for harvest like harvest() seems to be less flexible as the strategy needs more code to config the harvests and each harvest may need more than one tx (setting params, calling harvest).

@dantop114 dantop114 changed the title Consider adding harvest method to BaseStrategy 🎛️ Consider adding harvest method to BaseStrategy Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant