Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min-instances and max-pool-size #25

Open
fschwahn opened this issue Aug 11, 2015 · 3 comments
Open

min-instances and max-pool-size #25

fschwahn opened this issue Aug 11, 2015 · 3 comments

Comments

@fschwahn
Copy link

Hi,
first of all, I'm slightly confused why the Procfile in this example differs slightly from your new deployment walkthrough - is there a reason for this?

Secondly, in your Optimization Guide you write that process spawning should be minimized by setting max-pool-size and min-instances to the same value. Isn't heroku the perfect place to follow this advice, because there will always only be 1 app on a server? If it is indeed like that, maybe it makes sense to either adjust this example repo, or add this advice to the README.

What do you think?

All the best,
Fabian

@FooBarWidget
Copy link
Member

first of all, I'm slightly confused why the Procfile in this example differs slightly from your new deployment walkthrough - is there a reason for this?

I do not understand what you mean. The Procfile in the README is the exact same as the one in the deployment walkthrough. They both tell you to set web: bundle exec passenger start -p $PORT --max-pool-size 3.

Secondly, in your Optimization Guide you write that process spawning should be minimized by setting max-pool-size and min-instances to the same value. Isn't heroku the perfect place to follow this advice, because there will always only be 1 app on a server? If it is indeed like that, maybe it makes sense to either adjust this example repo, or add this advice to the README.

Yes, you have a point there. On the other hand, I do not want to bother people too much with configuration options when they are just starting to understand Passenger.

@fschwahn
Copy link
Author

Ah, I'm sorry about the first point, you are rights that in the README it is identical - however the file in the repository (https://github.com/phusion/passenger-ruby-heroku-demo/blob/master/Procfile) is slightly different. That's what I looked at.

@FooBarWidget
Copy link
Member

I see. I will have a look at that.

@FooBarWidget FooBarWidget reopened this Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants