Building statement with FORCE INDEX results in wrong SQL

[SteveTherrien]

Hello,

I have query that's not parsed or built properly when FORCE INDEX is used:

SELECT a.id, a.name, b.order_id, b.total
FROM customers a
INNER JOIN orders b FORCE INDEX (idx_customer_id)
    ON a.id = b.customer_id
WHERE a.status = 'active'

The query becomes:

SELECT a.id, a.name, b.order_id, b.total
FROM customers AS `a` FORCE INDEX (idx_customer_id)
INNER JOIN orders AS `b`
WHERE a.status = 'active'

• FORCE INDEX got moved from table orders onto customers.
• The a.id = b.customer_id join condition was removed.

I see the same linting errors as #497, so this is probably related.

Example code

<?php
require __DIR__ . '/vendor/autoload.php';

$in = <<<SQL
SELECT a.id, a.name, b.order_id, b.total
FROM customers a
INNER JOIN orders b FORCE INDEX (idx_customer_id)
    ON a.id = b.customer_id
WHERE a.status = 'active'
SQL;

$parser = new PhpMyAdmin\SqlParser\Parser($in);
$statement = $parser->statements[0];
echo $statement->build();

[williamdes]

Thank you for reporting this bug !
@niconoe- this one may be interesting for you

[niconoe-]

Yeah, this one might be something I could get involved into. I do think that #497 is very similar and fixing this will fix both.
Due to the holiday period, I won't be available until Jan. 06 at least, and I'll probably have profressional chores to do first before I could take a deeper look at this. But I'll try to investigate and propose something as soon as I can 😉 .

[williamdes]

Yeah, this one might be something I could get involved into. I do think that #497 is very similar and fixing this will fix both. Due to the holiday period, I won't be available until Jan. 06 at least, and I'll probably have profressional chores to do first before I could take a deeper look at this. But I'll try to investigate and propose something as soon as I can 😉 .

Sure, thank you for all your help !