-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline comments improperly removed during query #332
Comments
Note that this does not circumvent existing access controls; it cannot be used to escalate privileges. |
Can I work on this? |
@thesmallstar Yes, but you will maybe need to do changes on https://github.com/phpmyadmin/sql-parser/tree/QA |
@williamdes okay thank you :) |
Working on this. |
I've looked into the problem and I think adding a space after the comment token in the SQL parser would solve the problem. @ibennetch what do you think? |
Describe the bug
The query:
select * from /*!i*/nformation_schema.tables;
Executes as if it were:
select * from information_schema.tables;
This is improper.
Expected behavior
MySQL and MariaDB return an error message, this is probably the most expected result. Perhaps a syntax error should be generated from the parser.
Server configuration
Client configuration
This was originally reported by email.
The text was updated successfully, but these errors were encountered: