Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if string.strip_tags , mcrypt.*, and mdecrypt.* filters are still available in PHP 8 #3860

Open
Girgias opened this issue Oct 12, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@Girgias
Copy link
Member

Girgias commented Oct 12, 2024

Going through our filter documentation and saw the deprecation warning boxes.

If those are still available we need to add an issue on php-src to remove them in PHP 9, if not update the docs.

From manual page: https://php.net/filters.encryption


@Girgias Girgias added the good first issue Good for newcomers label Oct 12, 2024
@cmb69
Copy link
Member

cmb69 commented Oct 12, 2024

mcrypt.* and mdecrypt.* are no longer php-src concern, since ext/mcrypt has been unbundled. Not sure what to do with the documentation; https://pecl.php.net/package/mcrypt says no longer maintained, but had a couple of releases, the last one not even a year ago.

string.strip_tags is removed as of PHP 8.0.0 (https://heap.space/search?project=PHP-7.4&project=PHP-8.0&full=&defs=strfilter_strip_tags_create&refs=&path=&hist=&type=c).

@Girgias
Copy link
Member Author

Girgias commented Oct 12, 2024

We probably should say that it was removed from PHP in PHP 7.2.0, as this is when we removed it. We could add a secondary note that it is still available on PECL.

@cmb69
Copy link
Member

cmb69 commented Oct 12, 2024

Yeah, something like https://www.php.net/manual/en/intro.mcrypt.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants