-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with extracting buildings #18
Comments
Hi Lenivedz, thanks for posting this issue. I'll need to take a look at the raw data to see if this is an issue with OSM or an issue with Caribou. Could you post the the |
Hi, I can't attach osm.xlm file, so here is approximately area https://www.openstreetmap.org/#map=17/59.95610/30.30597 Yes, white ones are made manually (I made them by exporting vectors from same file in QGIS) I didn't use height data actually, i extruded buildings by extracting levels data and multiply it by 3.2 m. |
Hey, thanks for posting the site location, that makes it much easier for me to look into. I've been able to confirm a couple of things:
|
Hi, I've been using your Caribou library since yesterday and encountered this building import error... a superficial analysis of buildings that weren't imported revealed that their base geometry was a little more complex than just closed polygons, but in fact had one or more holes through them (example, interior courtyards). |
Hey, thanks for bringing this to my attention and for posting a clear test case. I should have some time to look at this over the next week. I think it should be either:
If there is another Grasshopper OSM importer that handles these types of geometries, let me know as it could help to narrow down the issue. |
Sure, I've been trying other importers, I will enumerate what I've tried so far:
I hope this helps you towards reaching the easier solution possible! |
Hey, thanks for bearing with me. It turns out this seems to be an issue with the metadata rather than anything too Caribou specific. In the file you've provided, the missing buildings don't actually have any height data specified for them in Open Street Map. You can verify this using the "Query Features" option in the OSM web viewer. In many cases, they also aren't tagged as "buildings", but it looks like the OSM web viewer has some smarts to interpret other metadata like I can see in Elk that it provides building outlines (not heights) in a similar fashion - presumably it has a special list of metadata that aren't
What were your thoughts? I realise that making 3D volumes from buildings is like 80% of the job for this kind of plugin in an architectural setting, but I'd like to not compromise the more GIS/meta-data stuff that I think is the most interesting part about Caribou. |
Hi, sorry for the delay. I've been looking at the query function on OSM and the unimported buildings I identified are indeed tagged as buildings You are very right that being able to quickly import the geometries is one the most important aspects of my workflow where I'm trying to simulate urban weather. I hope this issue can be circumvented since Caribou makes it really easy to filter by metadata and in no way would I want it to compromise this aspect. |
Hey, thanks for the follow up. I thought I had mentioned this in my original reply, but you are definitely right about the lack of multipolygon description precluding import of many of the buildings. That feature is definitely planned and involves parsing and grouping those geometry types as described here: #4. I might try and do a quick solution sometime soon, but the delay in getting to this was that I wanted to add it in without slowing down the parsing speed overall. I'll keep you posted when I get to it and when there's anything to test. |
Absolutely! My pleasure to bring up the issue and definitely will be looking forward to the next update. |
Hi, i faced with a problem while making gh definition.
I'm using "extract ways" node to extrude building, but I found, that it didn't extract all buildings from file.
For sure I opened same file in QGIS and missing buildings was there.
So I'm wandering where is problem (I tried to select all features for node, didn't help)
(img1 after adding missing buildings)
(img2 after baking definition)
The text was updated successfully, but these errors were encountered: