Skip to content
This repository has been archived by the owner on Sep 26, 2020. It is now read-only.

Unknown prop __passThrough being added to Children #3

Open
neeharv opened this issue Nov 8, 2016 · 3 comments
Open

Unknown prop __passThrough being added to Children #3

neeharv opened this issue Nov 8, 2016 · 3 comments

Comments

@neeharv
Copy link

neeharv commented Nov 8, 2016

Sample code from our codebase

<Swipeable onSwipeLeft={this.moveCarouselPrevious} onSwipeRight={this.moveCarouselPrevious}>
	<ul className={`${this.props.listType}-list`} ref="list" style={computedStyle}>
		{Children}
	</ul>
</Swipeable>
@johhansantana
Copy link

johhansantana commented Dec 6, 2016

Same here

when I have the children elements in the Swipleable I get the error

<Swipeable config={swipe} onSwipeLeft={this.checkSwipe}>
    <div>...</div>
</Swipeable>

but when I move the children to a dumb component

checkSwipe() {
  console.log('swipe');
}

<Swipeable config={swipe} onSwipeLeft={this.checkSwipe}>
  <CommerceList />
</Swipeable>

It removes the error but I can't log the swipe event.

@soriyath
Copy link

+1

@phil303
Copy link
Owner

phil303 commented Dec 20, 2016

Hey all, I haven't had a chance to look at this codebase all month since my wife and I have welcomed a newborn to the family. I'll try to make some time this week. PRs are welcome as well!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants