Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange cut in line of commits #116

Closed
pelmato opened this issue Nov 20, 2024 · 6 comments
Closed

Strange cut in line of commits #116

pelmato opened this issue Nov 20, 2024 · 6 comments

Comments

@pelmato
Copy link

pelmato commented Nov 20, 2024

Hello, new version (v0.1.22) has introduced strange cuts in the line of commits:
gitlg-bug

For comparison here is the same history with Git Graph:
git-graph-compare

I would say that there is a cut before a new color, but this is just an assumption.

Hope this helps you.
Thanks for your great work!

@dimateos
Copy link
Contributor

dimateos commented Nov 28, 2024

Your current theme affects it:
2024-11-28_(142529)_Code

But indeed it seems like with the default Dark+ theme there are lines between the commits.
As also shown in the pictures from the readme!

There could be a setting for toggling them, or alternative row colors for even/odd.
Probably already possible with the custom css?

You can also increasing line height to get more spacing:
image

@phil294
Copy link
Owner

phil294 commented Nov 28, 2024

Yes they are theme-dependent since recently, interesting that some themes seem to not have a particular color set to it. And I'm open for further style changes, unfortunately alternating colors looks pretty lame pretty fast.

But what @pelmato was referring to in this issue is the gap between the colored branch lines at the very left, such as between yellow circle and orange circle.

I have a fix for that already and actually a few more fixes and comments on other issues that I made last week on another machine, that I haven't pushed/submitted yet... so some of the things you commented on today @dimateos might already be solved, sorry. Should have pushed this right away. I'll have a look at everything tomorrow or so.

@dimateos
Copy link
Contributor

Oh I see the line cuts!

Regarding the lines and themes, if its controlled by the theme then the user can modify it in "workbench.colorCustomizations", do you know which is the color id used?


No problem about the stuff I commented on yesterday! At least there are actionable issues / places to discuss.
Take your time, -zero pressure etc ofc
I myself will check from time to time

Cheers

@phil294
Copy link
Owner

phil294 commented Nov 29, 2024

Yes, pretty sure that's sideBarSectionHeader-border.

(related: #115)

@dimateos
Copy link
Contributor

dimateos commented Dec 2, 2024

Yep its "sideBarSectionHeader.border" (note the dot, not dash), you can put it inside workbench.colorCustomizations" and override the theme:

image

@pelmato
Copy link
Author

pelmato commented Dec 9, 2024

It looks fine now with version 1.30.0. Thank you @phil294 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants