-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change sigmoid point in assess_dependencies #334
Comments
I'm not personally opposed to changing metrics to make them more useful, but I do think we'd need to be extra cautious with communication so that users are very mindful of changes to the metric calculations. If we were to change a metric, I'd prefer to have some empirical backing for the decision. One starting point might be to use Aside from having the right "feel", would you be able to motivate this change with some analytic rationale? |
I have some evidence that the sigmoid point should be adjusted upwards. We have riskmetric data on some internal packages and the following packages:
When calculating the average number of dependencies looking at When calculating the average number of dependencies looking at |
Description
Change dependencies sigmoid point to 20 in the function assess_dependencies (https://github.com/pharmaR/riskmetric/blob/master/R/assess_dependencies.R#L87)
update the examples for this function in lines 73, 76, 79
Regenerate the documentation
Use Case
This will allow for a more realistic number of dependent packages as five can be considered as too low.
The text was updated successfully, but these errors were encountered: