New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Joi? #133

Open

missinglink opened this issue Jul 21, 2020 · 1 comment

Assignees

Labels

bug

Member

missinglink commented Jul 21, 2020

I noticed that removing this line doesn't seem to affect the the tests or functionality of this module?

I'm not super familiar with Joi so I wasn't able to establish if it's safe to remove it?
There doesn't seem to be any Joi config in this module.

@orangejulius do you remember how this works?

missinglink added the bug label

missinglink assigned orangejulius

Member

orangejulius commented Jul 22, 2020

I think you're right, we can remove that line.

The way the config validation works is:

Modules that need config validation depend on Joi and define a schema (for example the API)
When calling pelias-config.generate(), the schema object is passed in, and then validated with Joi.

I tested things out, and we do need pelias/config to depend on Joi, for the tests if nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment